Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos CI #45

Merged
merged 1 commit into from
Dec 4, 2023
Merged

typos CI #45

merged 1 commit into from
Dec 4, 2023

Conversation

ArnoStrouwen
Copy link
Member

No description provided.

- name: Checkout Actions Repository
uses: actions/checkout@v3
- name: Check spelling
uses: crate-ci/typos@v1.16.23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably set dependabot to monthly in

interval: "weekly"

Otherwise, we will get a new PR every week if we fix a version like crate-ci/typos@v1.16.23 here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly @v1 does not work: crate-ci/typos#857

Maybe this would be better:

# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
version: 2
updates:
  - package-ecosystem: "github-actions"
    directory: "/" # Location of package manifests
    schedule:
      interval: "weekly"
    ignore:
      - dependency-name: "typos"
        update-types: ["version-update:semver-patch"]

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#specifying-dependencies-and-versions-to-ignore

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I would argue that it would still be nice to get updates of the spell checker.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will, just not the patch releases, only the minor upgrades.
Given the frequency they upgrade, that will likely suffice?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's sufficient.

@ChrisRackauckas ChrisRackauckas merged commit 2923bfa into SciML:master Dec 4, 2023
@ArnoStrouwen ArnoStrouwen deleted the typos branch December 4, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants