Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI trigger #348

Closed
wants to merge 1 commit into from
Closed

CI trigger #348

wants to merge 1 commit into from

Conversation

ArnoStrouwen
Copy link
Member

Tests are not passing locally for me, so triggering tests

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (138de9b) 83.79% compared to head (73d40a8) 83.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   83.79%   83.79%           
=======================================
  Files          28       28           
  Lines        2179     2179           
=======================================
  Hits         1826     1826           
  Misses        353      353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArnoStrouwen
Copy link
Member Author

These ones take much longer (stuck indefinitely?) on windows/mac compared to linux:
https://github.com/SciML/NonlinearSolve.jl/actions/runs/7430099659/job/20219416626?pr=348
This one fails on mac:
https://github.com/SciML/NonlinearSolve.jl/actions/runs/7430099659/job/20219417053?pr=348
Then there are a couple groups that fail all os.
@avik-pal can you take a look?

@avik-pal
Copy link
Member

avik-pal commented Jan 6, 2024

Let's hope #345 fixes all of these. I don't have a mac or windows to test locally.

@avik-pal avik-pal mentioned this pull request Jan 15, 2024
@avik-pal
Copy link
Member

Closing this, #345 tests on the 3 OSs. For mac everything seems fine. For windows, I have opened a corresponding issue.

@avik-pal avik-pal closed this Jan 15, 2024
@ArnoStrouwen ArnoStrouwen deleted the CItrigger branch January 15, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants