Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD Section in Documentation #354

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Jan 16, 2024

TODOs

Good Old Brusselator Benchmark

julia> @btime solve(prob_brusselator_2d, NewtonRaphson());
  402.717 ms (6959 allocations: 64.87 MiB)

julia> using PolyesterForwardDiff

julia> @btime solve(prob_brusselator_2d, NewtonRaphson());
  348.450 ms (333 allocations: 77.20 MiB)

Not changing the default, here, but mentioned in the docs on how to use polyester.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e0685a) 86.19% compared to head (812f6fb) 75.81%.
Report is 11 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #354       +/-   ##
===========================================
- Coverage   86.19%   75.81%   -10.39%     
===========================================
  Files          44       44               
  Lines        2608     2605        -3     
===========================================
- Hits         2248     1975      -273     
- Misses        360      630      +270     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal
Copy link
Member Author

I want to verify that this is better in most cases before switching the default

@avik-pal avik-pal changed the title Default to Polyester Forward Diff AD Section in Documentation Jan 30, 2024
@avik-pal avik-pal force-pushed the ap/polyester-forward-diff branch 3 times, most recently from ee67a53 to efa1c67 Compare January 30, 2024 11:58
@avik-pal
Copy link
Member Author

avik-pal commented Feb 5, 2024

@oscardssmith do you know what https://github.com/SciML/NonlinearSolve.jl/actions/runs/7786112451/job/21230175067?pr=354#step:6:14951 is? It seems to come from the Base.Experimental.@opaque, which I think you added.

@avik-pal avik-pal merged commit 6645ea4 into SciML:master Feb 5, 2024
22 of 26 checks passed
@avik-pal avik-pal deleted the ap/polyester-forward-diff branch February 5, 2024 16:16
@oscardssmith
Copy link
Contributor

It is. It means you are trying to AD a function even though the test specifically tells you not to AD it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants