Improve Rosenbrock finite difference by swapping dt with J #1611
+102
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YingboMa
reviewed
Mar 5, 2022
ChrisRackauckas
force-pushed
the
difftype
branch
from
d9aa5a3
to
c4eb8d7
Compare
YingboMa
approved these changes
Mar 5, 2022
src/nlsolve/nlsolve.jl
Outdated
|
|
||
| # This is for numerical differentiation cache correctness | ||
| # Requires Newton methods are FSAL | ||
| nlsolver.cache.du1 .= integrator.fsalfirst |
There was a problem hiding this comment.
Right, all the methods are programmatically FSAL for dense outputs, we should use it well. BTW, can we simply set integrator.fsalfirst === nlsolver.cache.du1? Will that lead to incorrectness?
There was a problem hiding this comment.
du1 can get overwritten/changed, for example in the central differencing method, so it's not always correct.
ChrisRackauckas
force-pushed
the
difftype
branch
2 times, most recently
from
ebc2d1b
to
328ca32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SciML/DifferentialEquations.jl#773