-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split the core of initdt to be algorithm independent #2007
base: master
Are you sure you want to change the base?
Conversation
This should reduce precompilation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generating a Review...
Shaves off 10-15s of pre-compilation time on my machine (from ~4m7s) Master trace: https://topolarity.github.io/trace-viewer/?trace=https%3A%2F%2Fraw.githubusercontent.com%2Ftopolarity%2Ftracy-traces%2Fdump%2Fdump%2Fmaster-OrdinaryDiffEq-cc46ec8b.tracy&size=2713067 Of the four-ish minutes, dominate components are:
Here are the heaviest per-function JIT hitters after this PR (in parentheses is the number of specializations): |
|
I guess we'd expect future inference times for In that case, my first-glance takeaway from the JIT list is that no single function is dominating the pre-compilation time ( |
This should reduce precompilation