Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match NonlinearSolve Downstream CI #2555

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Match NonlinearSolve Downstream CI #2555

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ae9a96a
match NonlinearSolve for Downstream DI develop
jClugstor Dec 10, 2024
63a9e01
forgot the shell
jClugstor Dec 10, 2024
ef10777
fix CI?
jClugstor Dec 10, 2024
b75a786
no slash?
jClugstor Dec 10, 2024
cb3c1e3
try this
jClugstor Dec 10, 2024
41c5c16
lib
jClugstor Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions .github/workflows/Downstream.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,6 @@ jobs:
# Explicitly develop the libraries first before running the tests for now.
# This is necessary since the tests are likely to fail otherwise, given that all
# the libs haven't been registered yet.
- name: "Develop the libraries since they haven't been registered yet"
run: |
julia --project=. -e '
using Pkg;
Pkg.develop(map(path ->Pkg.PackageSpec.(;path="$(@__DIR__)/lib/$(path)"), readdir("./lib")));
'
- name: Clone Downstream
uses: actions/checkout@v4
with:
Expand All @@ -64,6 +58,7 @@ jobs:
using Pkg
try
# force it to use this PR's version of the package
Pkg.develop(map(path ->Pkg.PackageSpec.(;path="lib/$(path)"), readdir("./lib")));
Pkg.develop(PackageSpec(path=".")) # resolver may fail with main deps
Pkg.update()
Pkg.test(coverage=true) # resolver may fail with test time deps
Expand All @@ -80,4 +75,4 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}
file: lcov.info
fail_ci_if_error: true
fail_ci_if_error: false
Loading