Skip to content

Make macro more type stable #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2025
Merged

Make macro more type stable #33

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68e0306
make backend more type stable
jClugstor Oct 21, 2025
da056c1
remove redundant macro def
jClugstor Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 17 additions & 23 deletions src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,26 +12,24 @@ abstract type AbstractVerbositySpecifier end

# Utilities

function message_level(verbose::AbstractVerbositySpecifier, option)
opt_level = getproperty(verbose, option)

if opt_level isa Silent
return nothing
elseif opt_level isa DebugLevel
function logging_message_level(option)
if option isa DebugLevel
return Logging.Debug
elseif opt_level isa InfoLevel
elseif option isa InfoLevel
return Logging.Info
elseif opt_level isa WarnLevel
elseif option isa WarnLevel
return Logging.Warn
elseif opt_level isa ErrorLevel
elseif option isa ErrorLevel
return Logging.Error
elseif opt_level isa CustomLevel
elseif option isa CustomLevel
return Logging.LogLevel(opt_level.level)
else
return nothing
end
end

function logging_message_level(option::Silent)
nothing
end

function emit_message(
f::Function, level, file, line,
_module)
Expand Down Expand Up @@ -60,7 +58,6 @@ function emit_message(message::String,
end
end


function emit_message(message::String,
level::Nothing, file, line, _module)
end
Expand Down Expand Up @@ -122,19 +119,16 @@ macro SciMLMessage(f_or_message, verb, option)
line = __source__.line
file = string(__source__.file)
_module = __module__
expr = :(emit_message($(esc(f_or_message)), message_level($(esc(verb)), $(esc(option))), $file, $line, $_module))
expr = quote
emit_message($(esc(f_or_message)),
logging_message_level(getproperty($(esc(verb)), $(esc(option)))),
$file,
$line,
$_module)
end
return expr
end

# For backwards compat to be not breaking. Also might be used in the future for log filtering.
macro SciMLMessage(f_or_message, verb, option, group)
line = __source__.line
file = string(__source__.file)
_module = __module__
return :(emit_message(
$(esc(f_or_message)), message_level($(esc(verb)), $(esc(option))), $file, $line, $_module))
end

"""
`verbosity_to_int(verb::AbstractMessageLevel)`

Expand Down