Split leaky testset into separate group #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The error in |
|
Given the timing, I think it may be JuliaLang/julia#52635. Make it a separate test set. |
|
reproducible steps: julia> using TestEnv; using Pkg; Pkg.activate("."); TestEnv.activate()
Activating project at `~/SciML/SciMLSensitivity.jl`
┌ Warning: Could not use exact versions of packages in manifest, re-resolving
└ @ TestEnv ~/.julia/packages/TestEnv/shkbW/src/julia-1.9/activate_set.jl:63
"/tmp/jl_xDgmEZ/Project.toml"
julia> cd("./test")
julia> using Test
julia> using SafeTestsets
julia> include("./adjoint_oop.jl")
Test Passedjulia> using TestEnv; using Pkg; Pkg.activate("."); TestEnv.activate()
Activating project at `~/SciML/SciMLSensitivity.jl`
┌ Warning: Could not use exact versions of packages in manifest, re-resolving
└ @ TestEnv ~/.julia/packages/TestEnv/shkbW/src/julia-1.9/activate_set.jl:63
"/tmp/jl_oHggLP/Project.toml"
julia> cd("./test")
julia> using Test
julia> using SafeTestsets
julia> include("./automatic_sensealg_choice.jl")
Precompiling Lux
15 dependencies successfully precompiled in 17 seconds. 100 already precompiled.
Precompiling ComponentArrays
1 dependency successfully precompiled in 1 seconds. 64 already precompiled.
Precompiling LuxComponentArraysExt
6 dependencies successfully precompiled in 7 seconds. 123 already precompiled.
Precompiling ComponentArraysRecursiveArrayToolsExt
5 dependencies successfully precompiled in 4 seconds. 133 already precompiled.
Precompiling ComponentArraysSciMLBaseExt
1 dependency successfully precompiled in 1 seconds. 132 already precompiled.
Precompiling LuxComponentArraysReverseDiffExt
1 dependency successfully precompiled in 2 seconds. 128 already precompiled.
┌ Warning: Using fallback BLAS replacements for (["ssymv_64_"]), performance may be degraded
└ @ Enzyme.Compiler ~/.julia/packages/GPUCompiler/U36Ed/src/utils.jl:59
true
julia> include("./adjoint_oop.jl")
ERROR: LoadError: Need an adjoint for constructor QuadratureAdjoint{0, true, Val{:central}, ZygoteVJP}. Gradient is of type ChainRulesCore.ZeroTangent
Stacktrace:
[1] error(s::String)
@ Base ./error.jl:35
[2] (::Zygote.Jnew{QuadratureAdjoint{0, true, Val{:central}, ZygoteVJP}, Nothing, false})(Δ::ChainRulesCore.ZeroTangent)
@ Zygote ~/.julia/packages/Zygote/jxHJc/src/lib/lib.jl:330
[3] (::Zygote.var"#2210#back#313"{Zygote.Jnew{QuadratureAdjoint{0, true, Val{:central}, ZygoteVJP}, Nothing, false}})(Δ::ChainRulesCore.ZeroTangent)
@ Zygote ~/.julia/packages/ZygoteRules/M4xmc/src/adjoint.jl:72
[4] QuadratureAdjoint
@ ~/SciML/SciMLSensitivity.jl/src/sensitivity_algorithms.jl:475 [inlined]
[5] (::Zygote.Pullback{Tuple{Type{QuadratureAdjoint{0, true, Val{:central}, ZygoteVJP}}, ZygoteVJP, Float64, Float64}, Any})(Δ::ChainRulesCore.ZeroTangent)
@ Zygote ~/.julia/packages/Zygote/jxHJc/src/compiler/interface2.jl:0
[6] #QuadratureAdjoint#6
@ ~/SciML/SciMLSensitivity.jl/src/sensitivity_algorithms.jl:483 [inlined]
[7] (::Zygote.Pullback{Tuple{SciMLSensitivity.var"##QuadratureAdjoint#6", Int64, Bool, Type{…}, ZygoteVJP, Float64, Float64, Type{…}}, Tuple{Zygote.Pullback{…}, Zygote.ZBack{…}}})(Δ::ChainRulesCore.ZeroTangent)
@ Zygote ~/.julia/packages/Zygote/jxHJc/src/compiler/interface2.jl:0
[8] QuadratureAdjoint
@ ~/SciML/SciMLSensitivity.jl/src/sensitivity_algorithms.jl:479 [inlined]
[9] (::Zygote.Pullback{Tuple{typeof(Core.kwcall), @NamedTuple{abstol::Float64, reltol::Float64, autojacvec::ZygoteVJP}, Type{QuadratureAdjoint}}, Any})(Δ::ChainRulesCore.ZeroTangent)
@ Zygote ~/.julia/packages/Zygote/jxHJc/src/compiler/interface2.jl:0
[10] #6
@ ~/SciML/SciMLSensitivity.jl/test/adjoint_oop.jl:185 [inlined]
[11] (::Zygote.Pullback{Tuple{…}, Tuple{…}})(Δ::Float64)
@ Zygote ~/.julia/packages/Zygote/jxHJc/src/compiler/interface2.jl:0
[12] (::Zygote.var"#75#76"{Zygote.Pullback{Tuple{…}, Tuple{…}}})(Δ::Float64)
@ Zygote ~/.julia/packages/Zygote/jxHJc/src/compiler/interface.jl:91
[13] gradient(::Function, ::SVector{2, Float64}, ::Vararg{Any})
@ Zygote ~/.julia/packages/Zygote/jxHJc/src/compiler/interface.jl:148
[14] top-level scope
@ ~/SciML/SciMLSensitivity.jl/test/adjoint_oop.jl:184
[15] include(fname::String)
@ Base.MainInclude ./client.jl:489
[16] top-level scope
@ REPL[7]:1
in expression starting at /home/arno/SciML/SciMLSensitivity.jl/test/adjoint_oop.jl:184
Some type information was truncated. Use `show(err)` to see complete types. |
|
Reduced to adding julia> using TestEnv; using Pkg; Pkg.activate("."); TestEnv.activate()
Activating project at `~/SciML/SciMLSensitivity.jl`
┌ Warning: Could not use exact versions of packages in manifest, re-resolving
└ @ TestEnv ~/.julia/packages/TestEnv/shkbW/src/julia-1.9/activate_set.jl:63
"/tmp/jl_uIW71Q/Project.toml"
julia> using Test
julia> using SafeTestsets
julia> using Lux
julia> cd("./test")
julia> include("adjoint_oop.jl")
ERROR: LoadError: Need an adjoint for constructor QuadratureAdjoint{0, true, Val{:central}, ZygoteVJP}. Gradient is of type ChainRulesCore.ZeroTangent
Stacktrace:
[1] error(s::String)
@ Base ./error.jl:35
[2] (::Zygote.Jnew{QuadratureAdjoint{0, true, Val{:central}, ZygoteVJP}, Nothing, false})(Δ::ChainRulesCore.ZeroTangent)
@ Zygote ~/.julia/packages/Zygote/jxHJc/src/lib/lib.jl:330
[3] (::Zygote.var"#2210#back#313"{Zygote.Jnew{QuadratureAdjoint{0, true, Val{:central}, ZygoteVJP}, Nothing, false}})(Δ::ChainRulesCore.ZeroTangent)
@ Zygote ~/.julia/packages/ZygoteRules/M4xmc/src/adjoint.jl:72
[4] QuadratureAdjoint
@ ~/SciML/SciMLSensitivity.jl/src/sensitivity_algorithms.jl:475 [inlined]
[5] (::Zygote.Pullback{Tuple{Type{QuadratureAdjoint{0, true, Val{:central}, ZygoteVJP}}, ZygoteVJP, Float64, Float64}, Any})(Δ::ChainRulesCore.ZeroTangent)
@ Zygote ~/.julia/packages/Zygote/jxHJc/src/compiler/interface2.jl:0
[6] #QuadratureAdjoint#6
@ ~/SciML/SciMLSensitivity.jl/src/sensitivity_algorithms.jl:483 [inlined]
[7] (::Zygote.Pullback{Tuple{SciMLSensitivity.var"##QuadratureAdjoint#6", Int64, Bool, Type{…}, ZygoteVJP, Float64, Float64, Type{…}}, Tuple{Zygote.Pullback{…}, Zygote.ZBack{…}}})(Δ::ChainRulesCore.ZeroTangent)
@ Zygote ~/.julia/packages/Zygote/jxHJc/src/compiler/interface2.jl:0
[8] QuadratureAdjoint
@ ~/SciML/SciMLSensitivity.jl/src/sensitivity_algorithms.jl:479 [inlined]
[9] (::Zygote.Pullback{Tuple{typeof(Core.kwcall), @NamedTuple{abstol::Float64, reltol::Float64, autojacvec::ZygoteVJP}, Type{QuadratureAdjoint}}, Any})(Δ::ChainRulesCore.ZeroTangent)
@ Zygote ~/.julia/packages/Zygote/jxHJc/src/compiler/interface2.jl:0
[10] #6
@ ~/SciML/SciMLSensitivity.jl/test/adjoint_oop.jl:185 [inlined]
[11] (::Zygote.Pullback{Tuple{…}, Tuple{…}})(Δ::Float64)
@ Zygote ~/.julia/packages/Zygote/jxHJc/src/compiler/interface2.jl:0
[12] (::Zygote.var"#75#76"{Zygote.Pullback{Tuple{…}, Tuple{…}}})(Δ::Float64)
@ Zygote ~/.julia/packages/Zygote/jxHJc/src/compiler/interface.jl:91
[13] gradient(::Function, ::SVector{2, Float64}, ::Vararg{Any})
@ Zygote ~/.julia/packages/Zygote/jxHJc/src/compiler/interface.jl:148
[14] top-level scope
@ ~/SciML/SciMLSensitivity.jl/test/adjoint_oop.jl:184
[15] include(fname::String)
@ Base.MainInclude ./client.jl:489
[16] top-level scope
@ REPL[7]:1
in expression starting at /home/arno/SciML/SciMLSensitivity.jl/test/adjoint_oop.jl:184
Some type information was truncated. Use `show(err)` to see complete types. |
|
IJust to be sure that I understand the problem, if you do using Lux the test starts to fail? |
See discussion SciML#1024
ArnoStrouwen
force-pushed
the
CI_TRIGGER
branch
from
a2b3d0e to
ed0c3ad
Compare
ArnoStrouwen
changed the title
|
Yes that is true, but it is worse than that since the using Lux can also be in a different safetestset. |
|
The new testset passed so this should be good to go: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1024 +/- ##
==========================================
+ Coverage 56.27% 58.17% +1.90%
==========================================
Files 19 19
Lines 4519 4519
==========================================
+ Hits 2543 2629 +86
+ Misses 1976 1890 -86 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.