Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classical Physics tutorial improvements #147

Merged
merged 7 commits into from
Mar 27, 2020

Conversation

SebastianM-C
Copy link
Contributor

@SebastianM-C SebastianM-C commented Mar 26, 2020

Hello! I made a couple of changes to the Classical Physics tutorial.

  • Show explicitly how to transform a second order ODE to a system of first order ODEs.
  • Add Simple Harmonic Oscillator
  • Move the equations to the top for double pendulum
  • Improve Poincaré section description
  • Prettier Poincaré section for double pendulum (remove artifacts)

I would also want to change the sections a bit (move First order linear ODE above Radioactive Decay of Carbon-14 and similar things, to go from general to particular).

When weaving the files (to html) I get the following error at the end

ERROR: KeyError: key :folder not found

I'm not sure if that matters. Edit: It does not.

Show explicitly how to transform a second order ODE to a system of first order ODEs.
Not the best notation
- Move the equations to the top
- Improve Poincaré section description
- Prettier Poincaré section (remove artifacts)
@ChrisRackauckas
Copy link
Member

Looks great! Can you add the weaved files?

@SebastianM-C
Copy link
Contributor Author

SebastianM-C commented Mar 26, 2020

Do you have any preference regarding the organization, or I can reorder as mentioned?

Can you add the weaved files?

I'm not sure how to generate them correctly. Is it from tests?

@ChrisRackauckas
Copy link
Member

feel free to reorder it. I don't have much of a preference there.

@SebastianM-C
Copy link
Contributor Author

I'm not sure how to generate them correctly.

I just saw in the README, sorry for the noise.

@SebastianM-C
Copy link
Contributor Author

Added the weaved files. I think there may be some minor things left (check for typos), but in principle this should be ready for review.

@SebastianM-C SebastianM-C marked this pull request as ready for review March 26, 2020 23:14
@ChrisRackauckas ChrisRackauckas merged commit 04ed74f into SciML:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants