Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for SDE problem with de.jit #153

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

himoto
Copy link
Contributor

@himoto himoto commented Nov 20, 2024

Checklist

Close #151

The purpose of this test is to confirm that the example code in READEM.md (the SDE problem with de.jit in Systems of SDEs with Diagonal Noise) works.

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

The test looks a bit sensitive to random seed. Maybe make the noise level a bit lower to make it a bit more stable.

@himoto
Copy link
Contributor Author

himoto commented Nov 21, 2024

The tests on ubuntu-latest are always successful, while they are unstable on MacOS. Also, the failure is not caused by de.jit, but by the Julia environment setup.

@ChrisRackauckas
Copy link
Member

Looks like it's stable now, the Python one seems to be a download issue.

@ChrisRackauckas ChrisRackauckas merged commit 5902fd5 into SciML:master Nov 21, 2024
3 of 4 checks passed
@himoto himoto deleted the test-sde branch November 21, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDE error with de.jit
2 participants