Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patches for stricteffects #31

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Conversation

ringabout
Copy link
Contributor

@ringabout ringabout commented Oct 6, 2022

ref nim-lang/Nim#19380

I checked locally, combined with HugoGranstrom/cdt#1 it should pass CI.

image

@HugoGranstrom
Copy link
Member

Thanks :)

I don't really understand what strictEffects is or why only newtons would be concerned though, there are multiple procs which looks very similar to it, for example steepest_decent?

@ringabout
Copy link
Contributor Author

Here is the documentation of https://nim-lang.github.io/Nim/manual.html#effect-system-effectsof-annotation

Basically, effectsOf tracks the effects of callbacks. With stricteffects, the effects of callback must be checked.

why only newtons would be concerned though, there are multiple procs which looks very similar to it, for example steepest_decent?

They should be marked too. I did minimal changes to make Nim CI green.

@HugoGranstrom
Copy link
Member

Ahhh okay, thanks for the explaination :D

I guess the reason only newtons needs this then is that it is the only proc which uses an explicit raises: [ArithmeticError]. Some day I should add it to all procs of numericalnim, but that day isn't today 😅

Merging this now and marking a new release so we can see if the Nim CI likes it now

@HugoGranstrom HugoGranstrom merged commit a3e8cf0 into SciNim:master Oct 7, 2022
@ringabout
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants