Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend mathematic operations support in the kmath-ast parser #120

Merged
merged 10 commits into from
Jul 27, 2020
Merged

Extend mathematic operations support in the kmath-ast parser #120

merged 10 commits into from
Jul 27, 2020

Conversation

CommanderTvis
Copy link
Collaborator

@CommanderTvis CommanderTvis commented Jul 20, 2020 •
edited
Loading

  • Add reference ANTLR grammar.
  • Add symbols support in ASM MST matcher.
  • Extend parser to support singular values (like i in ComplexField) as well as unary and binary functions.

closes #117

@CommanderTvis CommanderTvis requested a review from altavir July 26, 2020 17:28
@CommanderTvis CommanderTvis self-assigned this Jul 26, 2020
@CommanderTvis CommanderTvis added this to the 0.2 milestone Jul 26, 2020
@CommanderTvis CommanderTvis marked this pull request as draft July 27, 2020 07:35
@CommanderTvis
Copy link
Collaborator Author

CommanderTvis commented Jul 27, 2020 •
edited
Loading

Converting it to draft because of better-parse bug. h0tk3y/better-parse#28

@CommanderTvis CommanderTvis removed their assignment Jul 27, 2020
@CommanderTvis CommanderTvis linked an issue Jul 27, 2020 that may be closed by this pull request
Support all mathematic operations in the kmath-ast parser #117
Closed
@CommanderTvis CommanderTvis added the feature A new feature request label Jul 27, 2020
@CommanderTvis CommanderTvis marked this pull request as ready for review July 27, 2020 16:07
@altavir altavir merged commit e714c9b into dev Jul 27, 2020
@CommanderTvis CommanderTvis deleted the extended-grammar branch August 11, 2020 09:13
@CommanderTvis CommanderTvis modified the milestones: 0.2, 0.1.x Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shimuuar Shimuuar Shimuuar left review comments

@altavir altavir altavir approved these changes

Assignees
No one assigned
Labels
feature A new feature request
Projects
None yet
Milestone
0.1.x
Development

Successfully merging this pull request may close these issues.

Support all mathematic operations in the kmath-ast parser
3 participants
@CommanderTvis @Shimuuar @altavir