Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Levenberg-Marquardt algorithm and svd Golub-Kahan #513

Merged
merged 35 commits into from
Jun 19, 2023
Merged

Added Levenberg-Marquardt algorithm and svd Golub-Kahan #513

merged 35 commits into from
Jun 19, 2023

Conversation

margarita0303
Copy link
Contributor

No description provided.

@grinisrit grinisrit changed the title Addded Levenberg-Marquardt algorithm and svd Golub-Kahan Added Levenberg-Marquardt algorithm and svd Golub-Kahan May 7, 2023
SPC-code
SPC-code requested changes May 9, 2023
View reviewed changes
Copy link
Contributor

@SPC-code SPC-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main addition is a huge function that does not seem to require access to the algebra internals. I think it should be moved to a separate file as an extension. Also naming and parameter passing needs some work.

kmath-tensors/src/commonMain/kotlin/space/kscience/kmath/tensors/api/LinearOpsTensorAlgebra.kt Outdated Show resolved Hide resolved
kmath-tensors/src/commonMain/kotlin/space/kscience/kmath/tensors/api/LinearOpsTensorAlgebra.kt Outdated Show resolved Hide resolved
kmath-tensors/src/commonMain/kotlin/space/kscience/kmath/tensors/api/LinearOpsTensorAlgebra.kt Outdated Show resolved Hide resolved
kmath-tensors/src/commonMain/kotlin/space/kscience/kmath/tensors/api/LinearOpsTensorAlgebra.kt Outdated Show resolved Hide resolved
kmath-tensors/src/commonMain/kotlin/space/kscience/kmath/tensors/api/LinearOpsTensorAlgebra.kt Outdated Show resolved Hide resolved
kmath-tensors/src/commonMain/kotlin/space/kscience/kmath/tensors/api/LinearOpsTensorAlgebra.kt Outdated Show resolved Hide resolved
kmath-tensors/src/commonMain/kotlin/space/kscience/kmath/tensors/core/DoubleTensorAlgebra.kt Outdated Show resolved Hide resolved
CommanderTvis
CommanderTvis requested changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@CommanderTvis CommanderTvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unfamiliar with the algorithms, so only coding conventions were reported.

kmath-tensors/src/commonMain/kotlin/space/kscience/kmath/tensors/core/DoubleTensorAlgebra.kt Outdated Show resolved Hide resolved
kmath-tensors/src/commonMain/kotlin/space/kscience/kmath/tensors/core/DoubleTensorAlgebra.kt Outdated Show resolved Hide resolved
kmath-tensors/src/commonMain/kotlin/space/kscience/kmath/tensors/core/DoubleTensorAlgebra.kt Outdated Show resolved Hide resolved
@SPC-code
Copy link
Contributor

@margarita0303 You need to address all questions, bring the branch up to date with dev and re-request review.

SPC-code
SPC-code approved these changes Jun 11, 2023
View reviewed changes
Copy link
Contributor

@SPC-code SPC-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes (especially in naming must be done, but they could be done post-merge

@SPC-code
Copy link
Contributor

@grinisrit @CommanderTvis

@SPC-code SPC-code merged commit 7e46c7d into SciProgCentre:dev Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPC-code SPC-code SPC-code approved these changes

@CommanderTvis CommanderTvis CommanderTvis approved these changes

@grinisrit grinisrit Awaiting requested review from grinisrit

Assignees

@grinisrit grinisrit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@margarita0303 @SPC-code @CommanderTvis @grinisrit