ASM Bytecode Generation to unwrap Expressions of adv-expr API #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plementations to be available in constants
…API classes, make AsmCompiledExpression implement functional Expression, fix typos, encapsulate AsmGenerationContext
…to expose AsmGenerationContext to public API, refactor code
altavir
requested changes
Jun 7, 2020
There was a problem hiding this comment.
I think that the main problem is the exposed design. The AsmGenerationContext should be made private or internal and hidden from the user. Also I think that produced entities should inherid Expression so this functionality is compatible with functional implementation.
kmath-asm/src/main/kotlin/scientifik/kmath/expressions/AsmExpressions.kt
Outdated
Show resolved
Hide resolved
kmath-asm/src/main/kotlin/scientifik/kmath/expressions/AsmExpressions.kt
Outdated
Show resolved
Hide resolved
kmath-asm/src/main/kotlin/scientifik/kmath/expressions/AsmExpressions.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # kmath-core/src/commonMain/kotlin/scientifik/kmath/expressions/Expression.kt # kmath-core/src/commonMain/kotlin/scientifik/kmath/expressions/FunctionalExpressions.kt
…binaryOperation, improve ASM API accordingly
# Conflicts: # kmath-core/src/commonMain/kotlin/scientifik/kmath/expressions/Expression.kt
CommanderTvis
changed the title
altavir
reviewed
Jun 13, 2020
| @@ -0,0 +1,139 @@ | |||
| package scientifik.kmath.expressions | |||
There was a problem hiding this comment.
The rename is meaningless since there is no class with that name. FunctionalExpressionAlgebra is acceptable though.
altavir
reviewed
Jun 13, 2020
kmath-core/src/commonMain/kotlin/scientifik/kmath/expressions/Builders.kt
Show resolved
Hide resolved
altavir
reviewed
Jun 13, 2020
kmath-ast/src/jvmMain/kotlin/scientifik/kmath/asm/AsmExpressions.kt
Outdated
Show resolved
Hide resolved
altavir
reviewed
Jun 13, 2020
kmath-ast/src/jvmMain/kotlin/scientifik/kmath/asm/AsmExpressions.kt
Outdated
Show resolved
Hide resolved
altavir
reviewed
Jun 13, 2020
kmath-ast/src/jvmMain/kotlin/scientifik/kmath/asm/AsmGenerationContext.kt
Outdated
Show resolved
Hide resolved
altavir
reviewed
Jun 13, 2020
altavir
reviewed
Jun 13, 2020
altavir
reviewed
Jun 13, 2020
kmath-ast/src/jvmMain/kotlin/scientifik/kmath/asm/Optimization.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # kmath-ast/build.gradle.kts # kmath-ast/src/commonMain/kotlin/scientifik/kmath/ast/parser.kt # kmath-ast/src/jvmMain/kotlin/scientifik/kmath/ast/Parser.kt # kmath-ast/src/jvmMain/kotlin/scientifik/kmath/ast/parser.kt
…ke AsmNode (ex-AsmExpression) an abstract class instead of interface
altavir
approved these changes
Jun 13, 2020
CommanderTvis
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.