Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OStream#write accept multiple arguments #206

Merged
merged 5 commits into from
Aug 24, 2019
Merged

Make OStream#write accept multiple arguments #206

merged 5 commits into from
Aug 24, 2019

Conversation

kojix2
Copy link
Member

@kojix2 kojix2 commented Jun 21, 2019

@kojix2 kojix2 requested a review from mrkn June 21, 2019 01:52
mrkn
mrkn reviewed Jun 21, 2019
View reviewed changes
lib/iruby/ostream.rb Outdated Show resolved Hide resolved
mrkn
mrkn reviewed Aug 19, 2019
View reviewed changes
lib/iruby/ostream.rb Outdated Show resolved Hide resolved
mrkn
mrkn reviewed Aug 19, 2019
View reviewed changes
lib/iruby/ostream.rb Outdated Show resolved Hide resolved
mrkn
mrkn reviewed Aug 19, 2019
View reviewed changes
lib/iruby/ostream.rb Outdated Show resolved Hide resolved
mrkn
mrkn reviewed Aug 22, 2019
View reviewed changes
lib/iruby/ostream.rb Outdated Show resolved Hide resolved
mrkn
mrkn reviewed Aug 22, 2019
View reviewed changes
lib/iruby/ostream.rb Outdated

private

def building_string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a gerund is not fit to the method name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. That makes sense..

@mrkn mrkn merged commit 63b0b05 into SciRuby:master Aug 24, 2019
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 4, 2021
devel/ruby-iruby: update to 0.5.0
9e44518 
0.5.0 (2021-03-25)

Bug Fixes:

  * Fix Jupyter console crashes issue
    SciRuby/iruby#210 (@kojix2)
  * Fix syntax highlighting issue on Jpyter Lab
    SciRuby/iruby#224 (@kojix2)
  * Fix interoperability issue with ruby-git
    SciRuby/iruby#139 (@habemus-papadum)
  * Fix the issue of `$stderr.write` that cannot handle multiple arguments
    SciRuby/iruby#206 (@kojix2)
  * Remove a buggy `inspect_request` implementation
    SciRuby/iruby#119 (@LunarLanding)
  * Fix uninitialized constant `Fiddle` caused in initialization phase
    SciRuby/iruby#264 (@MatthewSteen, @kjoix2)
  * Fix the issue on displaying a table
    SciRuby/iruby#281 (@ankane)

Enhancements:

  * Add `IRuby.clear_output` method
    SciRuby/iruby#220 (@kojix2)
  * Make backtrace on exception simplify and more appropriate for code in a
    cell SciRuby/iruby#249 (@zheng-yongping)
  * Make syntax error message more appropriate
    SciRuby/iruby#251 (@zheng-yongping)
  * Remove top-level `In` and `Out` constants
    SciRuby/iruby#229 (@kojix2)
  * Use text/plain for the default format of `Numo::NArray` objects
    SciRuby/iruby#255 (@kojix2)
  * Use ffi-rzmq as the default ZeroMQ adapter
    SciRuby/iruby#256 (@kojix2)
  * Drop rbczmq support SciRuby/iruby#260
    (@rstammer)
  * Add ruby-vips image support SciRuby/iruby#279
    (@ankane)
  * Replace mimemagic with mime-types
    SciRuby/iruby#291 (@mrkn)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrkn mrkn mrkn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kojix2 @mrkn