Skip to content

Conversation

@tikkss
Copy link
Contributor

@tikkss tikkss commented Oct 22, 2024

Before change:

$ rake 2>&1 | grep 'iruby.*frozen'
/Users/zzz/src/github.com/SciRuby/iruby/lib/iruby/formatter.rb:128: warning: literal string will be frozen in the future
/Users/zzz/src/github.com/SciRuby/iruby/lib/iruby/formatter.rb:96: warning: literal string will be frozen in the future

After change:

$ rake 2>&1 | grep 'iruby.*frozen'

Before change:

```console
$ rake 2>&1 | grep 'iruby.*frozen'
/Users/zzz/src/github.com/SciRuby/iruby/lib/iruby/formatter.rb:128: warning: literal string will be frozen in the future
/Users/zzz/src/github.com/SciRuby/iruby/lib/iruby/formatter.rb:96: warning: literal string will be frozen in the future
```

After change:

```console
$ rake 2>&1 | grep 'iruby.*frozen'
```
@kojix2 kojix2 merged commit 12b07c4 into SciRuby:master Oct 22, 2024
@kojix2
Copy link
Member

kojix2 commented Oct 22, 2024

Thanks!
Good catch!

@tikkss tikkss deleted the suppress-frozen-string-literal-warning branch October 23, 2024 11:15
@tikkss
Copy link
Contributor Author

tikkss commented Oct 23, 2024

Thanks for your review!

@kojix2
Copy link
Member

kojix2 commented Oct 23, 2024

You're welcome.
Please send us a pull request again anytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants