Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rubygems-requirements-system to install system dependencies automatically #369

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

kou
Copy link
Contributor

@kou kou commented Apr 1, 2025

It's a successor product of native-package-installer.

See also:

It uses requirements in gemspec instead of installing system dependencies manually that is used approach by
native-package-installer.

It uses opt-in style. So users need to enable it explicitly by gem install rubygems-requirements-system or plugin "rubygems-requirements-system" in Gemfile.

@kou kou force-pushed the rubygems-requirements-system branch 2 times, most recently from b8624e2 to eca3feb Compare April 1, 2025 03:51
…atically

It's a successor product of native-package-installer.

See also:
* https://github.com/ruby-gnome/rubygems-requirements-system/
* https://github.com/ruby-gnome/native-package-installer

It uses `requirements` in gemspec instead of installing system
dependencies manually that is used approach by
native-package-installer.

It uses opt-in style. So users need to enable it explicitly by `gem
install rubygems-requirements-system` or `plugin
"rubygems-requirements-system"` in `Gemfile`.
@kojix2
Copy link
Member

kojix2 commented Apr 2, 2025

Hi @kou

Thank you for the pull request.
It might be easier to ask on Element, but since GitHub is more accessible to others, I’ll ask here.

I’m not sure I fully understand the relationship between native-package-installer and rubygems-requirements-system.

Are you planning to replace native-package-installer with rubygems-requirements-system in the future?
Or is rubygems-requirements-system just an alternative for specific use cases?

Would you recommend using rubygems-requirements-system when creating a new gem that depends on system libraries?
Also, do you plan to migrate gems like gtk3 and gtk4 to use rubygems-requirements-system?

@kojix2
Copy link
Member

kojix2 commented Apr 2, 2025

I just found your Japanese blog post about rubygems-requirements-system.
[JA] https://www.clear-code.com/blog/2025/1/17/goodbye-fat-gem-2025.html

@kou
Copy link
Contributor Author

kou commented Apr 2, 2025

Are you planning to replace native-package-installer with rubygems-requirements-system in the future? Or is rubygems-requirements-system just an alternative for specific use cases?

The former. rubygems-requirements-system is a successor of native-package-installer.

Would you recommend using rubygems-requirements-system when creating a new gem that depends on system libraries?

Yes.

Also, do you plan to migrate gems like gtk3 and gtk4 to use rubygems-requirements-system?

It's already done: https://github.com/ruby-gnome/ruby-gnome/releases/tag/4.2.9

But they still have configurations for native-package-installer for smooth migration. But I'll remove native-package-installer dependency from them eventually.

@kou
Copy link
Contributor Author

kou commented Apr 5, 2025

Could you merge this and release a new version?
We want this change for RedAmber.

@kojix2 kojix2 requested a review from Copilot April 8, 2025 11:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • ext/Rakefile: Language not supported

@kojix2 kojix2 merged commit 6c23502 into SciRuby:master Apr 8, 2025
9 of 11 checks passed
@kojix2
Copy link
Member

kojix2 commented Apr 8, 2025

Thank you.
If you find any problems, please send me another pull request.

@kou
Copy link
Contributor Author

kou commented Apr 9, 2025

Sure.

@kou kou deleted the rubygems-requirements-system branch April 9, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants