fix: Google realtime communication

[gunpal5]

PR Type

Bug fix, Enhancement, Configuration changes

---

Description

• Fixed audio sample rate in WaveStreamChannel to 16000 Hz.

• Enhanced RealTimeCompletionProvider to support additional audio format metadata.

• Updated Google AI model configuration in appsettings.json.

• Improved handling of model setup with ToModelId conversion.

---

Changes walkthrough 📝

	Relevant files
Bug fix	WaveStreamChannel.cs Adjusted audio sample rate in `WaveStreamChannel`                src/Infrastructure/BotSharp.Core.Realtime/Services/WaveStreamChannel.cs Changed audio sample rate from 24000 Hz to 16000 Hz. Ensured compatibility with updated audio processing requirements. +1/-1
Enhancement	RealTimeCompletionProvider.cs Enhanced real-time audio and model setup handling                src/Plugins/BotSharp.Plugin.GoogleAI/Providers/Realtime/RealTimeCompletionProvider.cs Added optional parameter to ConnectAsync method. Enhanced SendAudioAsync to include audio format metadata. Updated model setup to use ToModelId conversion. Commented out unused configuration code for clarity. +7/-3
Configuration changes	appsettings.json Updated Google AI model and real-time settings                      tests/BotSharp.Test.RealtimeVoice/appsettings.json Updated Google AI model name to gemini-2.0-flash-live-001. Added InterruptResponse configuration under RealtimeModel. Refined configuration for real-time model provider and formats. +5/-2

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[GGHansome]

Auto Review Result:

Code Review Summary

Summary of Changes: The code modifications include adjusting audio settings in the WaveStreamChannel and modifying method calls in RealTimeCompletionProvider. The impact involves changing the audio sampling rate and correcting method signatures to ensure proper parameter passing.

Issues Identified

Issue 1: [Audio Configuration]

• Description: The wave format sampling rate was changed from 24000 Hz to 16000 Hz. The comment, however, was not updated and still inaccurately reflects the previous setting.
• Suggestion: Update the comment to accurately describe the new audio format configuration.
• Example:

  // Before
  WaveFormat = new WaveFormat(24000, 16, 1), // 24000 Hz, 16-bit PCM, Mono
  // After
  WaveFormat = new WaveFormat(16000, 16, 1), // 16000 Hz, 16-bit PCM, Mono
  

Issue 2: [Method Invocation]

• Description: The _client.ConnectAsync() method now takes a false parameter, which might indicate changing the default behavior of the connection setup.
• Suggestion: If false alters the connection logic, ensure related documentation and tests are updated to reflect this change to prevent unexpected behaviors.

Issue 3: [MIME Type Specification]

• Description: In the _client.SendAudioAsync() method call, a MIME type "audio/pcm;rate=16000" was added, which clarifies the audio format but requires validation with the API.
• Suggestion: Confirm the API accepts this MIME type format and that the addition does not break other parts of the system.

Issue 4: [Commented Code]

• Description: Several lines of code have been commented out without explanation, which could lead to confusion or maintenance challenges.
• Suggestion: Either add comments to explain why they are commented or remove them if they are no longer needed.

Overall Evaluation

The code provides a necessary update to the audio settings and method contracts but requires improved comments to reflect these changes accurately. Additionally, ensure all modifications align with the system’s expectations and update documentation accordingly. Code readability and maintainability will benefit from addressing the commented-out code.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Model Reference The code now uses Model.ToModelId() instead of directly using Model. Ensure this conversion method exists and properly formats the model identifier as expected by the Google AI API. Model = Model.ToModelId(), SystemInstruction = request.SystemInstruction, Commented Code There are commented-out lines of code that appear to be debugging or development artifacts. Consider removing these comments if they're no longer needed. // if(request.Tools.Count == 0) // request.Tools = null; // config.MaxOutputTokens = null;

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Remove invalid trailing comma Remove the trailing comma after the "InterruptResponse": false property. This is invalid JSON syntax and will cause parsing errors. tests/BotSharp.Test.RealtimeVoice/appsettings.json [50-56] "RealtimeModel": { "Provider": "google-ai", "Model": "gemini-2.0-flash-live-001", "InputAudioFormat": "pcm16", "OutputAudioFormat": "pcm16", - "InterruptResponse": false, + "InterruptResponse": false }, Apply this suggestion Suggestion importance[1-10]: 8 __ Why: Trailing commas in JSON objects are invalid according to the JSON specification and will cause parsing errors. Removing this syntax error is critical to ensure the application can properly load its configuration.	Medium
General	Fix misleading comment The comment still mentions "24000 Hz" while the actual code now uses 16000 Hz. Update the comment to match the new sample rate for clarity and to avoid confusion. src/Infrastructure/BotSharp.Core.Realtime/Services/WaveStreamChannel.cs [27-29] _waveIn = new WaveInEvent { DeviceNumber = 0, // Default recording device - WaveFormat = new WaveFormat(16000, 16, 1), // 24000 Hz, 16-bit PCM, Mono + WaveFormat = new WaveFormat(16000, 16, 1), // 16000 Hz, 16-bit PCM, Mono BufferMilliseconds = 100 }; [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 5 __ Why: The comment still references "24000 Hz" while the actual code now uses 16000 Hz. Updating the comment to match the actual sample rate improves code clarity and prevents confusion for future developers.	Low
More