Skip to content

PEOL-187 hotfix System object Disposed Exception: Cannot access a dis… #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yileicn merged 1 commit into from
Apr 17, 2025
Merged

PEOL-187 hotfix System object Disposed Exception: Cannot access a dis… #1013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/Infrastructure/BotSharp.Core.Crontab/Services/CrontabEventSubscription.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,17 @@ await subscriber.SubscribeAsync($"Crontab:{item.Title}",
"Crontab",
port: 0,
priorityEnabled: false,
async (sender, args) =>
{
var scope = _services.CreateScope();
cron = scope.ServiceProvider.GetRequiredService<ICrontabService>();
await cron.ScheduledTimeArrived(item);
},
async (sender, args) => await HandleCrontabEvent(item),
stoppingToken: stoppingToken);
});
}
}
}

private async Task HandleCrontabEvent(CrontabItem item)
{
using var scope = _services.CreateScope();
var cron = scope.ServiceProvider.GetRequiredService<ICrontabService>();
await cron.ScheduledTimeArrived(item);
}
}
11 changes: 8 additions & 3 deletions src/Infrastructure/BotSharp.Core.Crontab/Services/CrontabWatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,7 @@ private async Task RunCronChecker(IServiceProvider services)
}
else
{
var scope = _services.CreateScope();
cron = scope.ServiceProvider.GetRequiredService<ICrontabService>();
cron.ScheduledTimeArrived(item);
await HandleCrontabEvent(item);
}
}
}
Expand All @@ -107,6 +105,13 @@ private async Task RunCronChecker(IServiceProvider services)
}
}

private async Task HandleCrontabEvent(CrontabItem item)
{
using var scope = _services.CreateScope();
var cron = scope.ServiceProvider.GetRequiredService<ICrontabService>();
await cron.ScheduledTimeArrived(item);
}

private DateTime GetLastOccurrence(CrontabSchedule schedule)
{
var nextOccurrence = schedule.GetNextOccurrence(DateTime.UtcNow);
Expand Down
Loading