refine chat stream request

[iceljc]

PR Type

Enhancement

---

Description

• Refactored chat stream initialization to use structured request object

• Replaced direct state list deserialization with ChatStreamRequest model

• Added new ChatStreamRequest class for better data structure

---

Changes diagram

flowchart LR
  A["Raw JSON Data"] --> B["ChatStreamRequest Model"]
  B --> C["States Property"]
  C --> D["ConnectToModel Method"]

Loading

---

Changes walkthrough 📝

Relevant files

Enhancement

ChatStreamMiddleware.cs Refactor initialization to use request model                          src/Plugins/BotSharp.Plugin.ChatHub/ChatStreamMiddleware.cs Renamed InitStates method to InitRequest returning ChatStreamRequest Updated method call to access states via request?.States Changed deserialization target from List to ChatStreamRequest Modified error handling to return null instead of empty list +5/-6      ChatStreamRequest.cs Add ChatStreamRequest model class                                                src/Plugins/BotSharp.Plugin.ChatHub/Models/Stream/ChatStreamRequest.cs Added new ChatStreamRequest class with States property Implemented JSON property name mapping for states field Initialized States as empty list by default +10/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Null Reference The code uses null-conditional operator on request?.States but doesn't handle the case where request is null, which could lead to passing null to ConnectToModel method that may expect a valid collection. var request = InitRequest(data); await ConnectToModel(hub, webSocket, request?.States); Missing Validation The States property lacks null safety validation and could potentially be set to null externally, breaking the assumption that it should always be a valid list. [JsonPropertyName("states")] public List<MessageState> States { get; set; } = [];

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Provide fallback for null states The null-conditional operator may pass null to ConnectToModel if request is null. Consider providing a fallback empty list to maintain consistent behavior and prevent potential null reference issues downstream. src/Plugins/BotSharp.Plugin.ChatHub/ChatStreamMiddleware.cs [86] -await ConnectToModel(hub, webSocket, request?.States); +await ConnectToModel(hub, webSocket, request?.States ?? []); Apply / Chat Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies that request can be null, which would pass a null value to ConnectToModel. The proposed change restores the previous behavior of passing an empty list, preventing potential null reference exceptions downstream.	Medium
More