Delay one second inside LockAsync in crontab watcher #1187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Description
Moved delay inside distributed lock to prevent race conditions
Changed delay timing from before lock to after cron checker execution
Diagram Walkthrough
File Walkthrough
CrontabWatcher.cs
Relocate delay inside distributed lock callback
src/Infrastructure/BotSharp.Core.Crontab/Services/CrontabWatcher.cs
Task.Delay(1000)
from outside to inside theLockAsync
callbackRunCronChecker
execution instead of before lockacquisition