add audio service to transcribe local mp3/wav file #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hchen2020
reviewed
Jul 29, 2024
| #if DEBUG | ||
| [AllowAnonymous] | ||
| #endif | ||
| [Route("[controller]/text/[action]")] |
There was a problem hiding this comment.
Remove this to specific function.
hchen2020
reviewed
Jul 29, 2024
| _audioService = audioService; | ||
| } | ||
|
|
||
| [HttpGet] |
There was a problem hiding this comment.
[HttGet("audio/transcript"]
hchen2020
reviewed
Jul 29, 2024
|
|
||
| public Stream ConvertMp3ToStream(string mp3FileName) | ||
| { | ||
| var fileStream = File.OpenRead(mp3FileName); |
There was a problem hiding this comment.
Change to using var fileStream =
There was a problem hiding this comment.
I tested it on my local. Adding "using" statement at the beginning will result in a disposed "fileStream" if SampleRate is 16000. The value returned by this function will not contain any data.
hchen2020
reviewed
Jul 29, 2024
| public Stream ConvertMp3ToStream(string mp3FileName) | ||
| { | ||
| var fileStream = File.OpenRead(mp3FileName); | ||
| var reader = new Mp3FileReader(fileStream); |
hchen2020
reviewed
Jul 29, 2024
| public class AudioInput | ||
| { | ||
| public string FilePath { get; set; } | ||
| public Stream stream { get; set; } |
added 2 commits
July 29, 2024 15:31
Oceania2018
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.