Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Jupyter Lab #11

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Support Jupyter Lab #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5ee258
After processing the request and publishing associated IOPub messages…
unc0 Jan 13, 2020
6511a73
Don't send 'source' in DisplayData then Jupyter won't show warnings f…
unc0 Jan 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/ICSharpCore.Primitives/DisplayData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ namespace ICSharpCore.Primitives
/// </summary>
public class DisplayData
{
[JsonProperty("source")]
public string Source { get; set; }

[JsonProperty("data")]
public JObject Data { get; set; }

Expand All @@ -27,7 +24,6 @@ public class DisplayData

public DisplayData()
{
Source = string.Empty;
Data = new JObject();
MetaData = new JObject();
Transient = new JObject();
Expand Down
5 changes: 4 additions & 1 deletion src/ICSharpCore/Kernels/Kernel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public void Start()
{
var message = new Message<KernelInfoRequest>(header, raw);
iopubSender.Send(message,
new Status { ExecutionState = StatusType.Busy },
new Status { ExecutionState = StatusType.Idle },
MessageType.Status);
_kernelInfoHandler.Process(message);
}
Expand All @@ -80,6 +80,9 @@ public void Start()
new Status { ExecutionState = StatusType.Busy },
MessageType.Status);
_executeHandler.Process(message);
iopubSender.Send(message,
new Status { ExecutionState = StatusType.Idle },
MessageType.Status);
}
break;
}
Expand Down