Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the github build actions for Vulkan #794

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Add the github build actions for Vulkan #794

merged 1 commit into from
Jun 18, 2024

Conversation

m0nsky
Copy link
Contributor

@m0nsky m0nsky commented Jun 18, 2024

Haven't got any experience with contributing to and opening PR's in repos other than private/local, so let's give this a try. This PR adds the required build actions for Vulkan so the binaries can be built.

If I have understood the previous discussion correctly and this PR goes well, I will:

  • Add Vulkan to the NativeLibraryConfig
  • Add the runtime targets
  • Add the nuspec

And finally I will look into auto loading of the library under Windows and WSL, I will see if I can find someone with an AMD GPU to help with the testing. If this goes well also, I would be fine with maintaining the parser.

@martindevans
Copy link
Member

Would you mind kicking off a test run of the "Update Binaries" build action in your fork? If that completes successfully we can merge this PR.

@m0nsky
Copy link
Contributor Author

m0nsky commented Jun 18, 2024

Is this something that should be done locally or through github? I've tried looking around on the "Actions" page on my fork but can't find anything there.

@martindevans
Copy link
Member

firefox_2024-06-18_18-42-05

It should be here I think, not sure why it's not. Try checking in settings that actions aren't disabled:

firefox_2024-06-18_18-44-50

@m0nsky
Copy link
Contributor Author

m0nsky commented Jun 18, 2024

Yeah, that page is empty, and that setting is set to "Allow all", just checked it again.

@m0nsky m0nsky changed the base branch from master to monsky_temp_pr_branch June 18, 2024 20:32
@martindevans
Copy link
Member

We're merging this into a new temporary branch called monsky_temp_pr_branch to workaround an issue with GitHub actions beign unable to run in the forked repo.

@martindevans martindevans merged commit 6ebd60b into SciSharp:monsky_temp_pr_branch Jun 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants