Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bilinear regridding support #148

Merged
merged 32 commits into from
Mar 15, 2022
Merged

Conversation

stephenworsley
Copy link
Contributor

Adds support for bilinear regridding for the unstructured regridders.

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #148 (845b6a1) into main (baa1030) will decrease coverage by 0.05%.
The diff coverage is 99.38%.

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   99.56%   99.51%   -0.06%     
==========================================
  Files          27       27              
  Lines        2073     2469     +396     
==========================================
+ Hits         2064     2457     +393     
- Misses          9       12       +3     
Impacted Files Coverage Δ
esmf_regrid/experimental/unstructured_regrid.py 97.36% <90.00%> (-2.64%) ⬇️
esmf_regrid/experimental/unstructured_scheme.py 99.11% <97.10%> (-0.89%) ⬇️
esmf_regrid/_esmf_sdo.py 97.16% <100.00%> (+0.20%) ⬆️
esmf_regrid/esmf_regridder.py 95.08% <100.00%> (+0.53%) ⬆️
esmf_regrid/experimental/io.py 100.00% <100.00%> (ø)
...regrid/tests/unit/esmf_regridder/test_Regridder.py 100.00% <100.00%> (ø)
.../tests/unit/experimental/io/test_round_tripping.py 100.00% <100.00%> (ø)
...nstructured_scheme/test_GridToMeshESMFRegridder.py 100.00% <100.00%> (ø)
...nstructured_scheme/test_MeshToGridESMFRegridder.py 100.00% <100.00%> (ø)
...ntal/unstructured_scheme/test__cube_to_GridInfo.py 100.00% <100.00%> (ø)
... and 5 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@stephenworsley stephenworsley marked this pull request as ready for review February 23, 2022 14:34
@stephenworsley stephenworsley changed the base branch from unstructured_scheme to main February 23, 2022 15:13
@trexfeathers trexfeathers self-assigned this Mar 9, 2022
@trexfeathers
Copy link
Contributor

@stephenworsley #162 might solve the CI failures (unless you think the regressions are genuine)?

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK @stephenworsley, here's my review of the functionality.

Please could you also merge in the latest main, which should avoid the various benchmarking failures we seem to be suffering.

I will move on to reviewing the tests next.

esmf_regrid/_esmf_sdo.py Show resolved Hide resolved
esmf_regrid/esmf_regridder.py Outdated Show resolved Hide resolved
esmf_regrid/esmf_regridder.py Outdated Show resolved Hide resolved
esmf_regrid/esmf_regridder.py Show resolved Hide resolved
esmf_regrid/experimental/io.py Outdated Show resolved Hide resolved
esmf_regrid/experimental/unstructured_scheme.py Outdated Show resolved Hide resolved
esmf_regrid/experimental/unstructured_scheme.py Outdated Show resolved Hide resolved
esmf_regrid/experimental/unstructured_scheme.py Outdated Show resolved Hide resolved
esmf_regrid/experimental/unstructured_scheme.py Outdated Show resolved Hide resolved
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the tests somewhat:

  • Read the coverage report to confirm that the additional code is being exercised in the tests.
  • Confirmed that the tests are passing.
  • Skim read the tests themselves to check that they make sense.
    (Not being an expert in this area, I can't pretend to have been super-thorough).

I think that's enough for what we need!

Couple of requests for you.

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @stephenworsley, looking forward to our users enjoying this new feature 🙂

@trexfeathers trexfeathers merged commit f97a0bf into SciTools:main Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants