-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bilinear regridding support #148
Conversation
Codecov Report
@@ Coverage Diff @@
## main #148 +/- ##
==========================================
- Coverage 99.56% 99.51% -0.06%
==========================================
Files 27 27
Lines 2073 2469 +396
==========================================
+ Hits 2064 2457 +393
- Misses 9 12 +3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@stephenworsley #162 might solve the CI failures (unless you think the regressions are genuine)? |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK @stephenworsley, here's my review of the functionality.
Please could you also merge in the latest main
, which should avoid the various benchmarking failures we seem to be suffering.
I will move on to reviewing the tests next.
f979f4b
to
30615a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed the tests somewhat:
- Read the coverage report to confirm that the additional code is being exercised in the tests.
- Confirmed that the tests are passing.
- Skim read the tests themselves to check that they make sense.
(Not being an expert in this area, I can't pretend to have been super-thorough).
I think that's enough for what we need!
Couple of requests for you.
esmf_regrid/tests/unit/experimental/unstuctured_regrid/test_MeshInfo.py
Outdated
Show resolved
Hide resolved
esmf_regrid/tests/unit/experimental/unstructured_scheme/test__mesh_to_MeshInfo.py
Outdated
Show resolved
Hide resolved
esmf_regrid/tests/unit/experimental/unstructured_scheme/test__mesh_to_MeshInfo.py
Outdated
Show resolved
Hide resolved
…mesh_to_MeshInfo.py Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @stephenworsley, looking forward to our users enjoying this new feature 🙂
Adds support for bilinear regridding for the unstructured regridders.