Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase standard benchmark regression tolerance #162

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

trexfeathers
Copy link
Contributor

Benchmarks are currently over-sensitive and regularly flag false positive regressions.

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #162 (bc36fed) into main (039ce21) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          27       27           
  Lines        2073     2073           
=======================================
  Hits         2064     2064           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 039ce21...bc36fed. Read the comment docs.

@stephenworsley
Copy link
Contributor

I suspect that we might also want to reduce the number of test cases we use as well for the sake of time, though given the kind of variability we're seeing this is probably also necessary.

Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@stephenworsley stephenworsley merged commit baa1030 into SciTools:main Mar 9, 2022
@trexfeathers trexfeathers deleted the bm_tolerance branch March 31, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants