-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarking overhaul and pin Flake8 <6 #220
Benchmarking overhaul and pin Flake8 <6 #220
Conversation
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
=======================================
Coverage 99.36% 99.36%
=======================================
Files 28 28
Lines 2829 2829
=======================================
Hits 2811 2811
Misses 18 18 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Just one comment about the license header in one file.
Flake8 failure seems possibly related to PyCQA/flake8#1739, but I have not yet worked out what in our config is causing the problem. |
See also PyCQA/flake8#1758 |
Happens even without any config at all in |
Should be fixed once PyCQA/flake8-import-order#190 is in a release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I guess we can ignore the greetings failure for the time being as that seems to be a seperable issue.
A detailed restructure of the benchmarking architecture in line with what has already been done on SciTools/iris. The original architecture included several experiments which we have since iterated and improved within Iris.
Closes #210.