Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new images for the example tests when GEOS was updated. #9

Closed
wants to merge 1 commit into from

Conversation

pelson
Copy link

@pelson pelson commented Nov 7, 2017

The hamming distance between this and other images is rather close. Perhaps we would be better modifying that... ?

@pelson
Copy link
Author

pelson commented Nov 8, 2017

Turns out, this is the wrong repo... Should be https://github.com/SciTools/test-iris-imagehash, right?

Which begs the question - what is this repo for? 😭

@bjlittle
Copy link
Member

bjlittle commented Nov 8, 2017

@pelson Ahh yes ... if I recall rightly, we took two attempts at implementing the image hashing - one with sha (too volatile) and one with perceptual image hashing (more robust). This repo is the old unused repo i.e. sha base one, which makes sense from the CI test.

Also, the URL referenced by iris/tests/idiff confirms this.

Why can't we just delete this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants