Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the 'from waves import sample_data' line in the 'Contour labels' and the 'Contour transform options' examples ? #2270

Closed
jypeter opened this issue Jul 1, 2022 · 3 comments

Comments

@jypeter
Copy link

jypeter commented Jul 1, 2022

I have visited the Contour labels and the Contour transform options Gallery pages, and both examples use from waves import sample_data

Trouble is that I just get an error if I do that !

>>> from waves import sample_data
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'waves'

I searched the cartopy site and discovered that waves was apparently the example script for the Filled contours Gallery page !!

Having to dig this way to find a dependency is not to great... Can you improve the Gallery examples that need the sample_data function to tell the user where to find waves.py, or just redefine the sample_data function in all the scripts that need it?

@rcomer
Copy link
Member

rcomer commented Oct 13, 2023

I think this issue belongs in the Cartopy repo, so I am moving it with my newly acquired powers…

@rcomer rcomer transferred this issue from SciTools/scitools.org.uk Oct 13, 2023
@rcomer
Copy link
Member

rcomer commented Oct 13, 2023

Actually it looks like this was done at #2044.

@rcomer rcomer closed this as completed Oct 13, 2023
@jypeter
Copy link
Author

jypeter commented Oct 13, 2023

Thanks for having checked that !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants