examples: define 'sample_data' for all examples #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
May 10, 2022
Ever since 297e1cb (Moving sample_data imports out of cartopy namespace., 2020-07-23), some examples are not self-contained since they want to import 'sample_data' from a non-existing module like 'waves' or 'arrows'. Add the required 'sample_data' function to make all examples self-contained. For 'contour_labels.py' and 'contour_transforms.py', the function is copied from 'waves.py'. For 'barbs.py' and 'streamplot.py', the function is copied from 'arrows.py'.
phil-blain
force-pushed
the
examples-self-contained-sample-data
branch
from
8d34618 to
2fa98f9
Compare
greglucas
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since 297e1cb (Moving sample_data imports out of cartopy
namespace., 2020-07-23), some examples are not self-contained since they
want to import 'sample_data' from a non-existing module like 'waves' or
'arrows'.
Add the required 'sample_data' function to make all examples
self-contained. For 'contour_labels.py' and 'contour_transforms.py', the
function is copied from 'waves.py'. For 'barbs.py' and 'streamplot.py',
the function is copied from 'arrows.py'.
Rationale
Make all examples self-contained.
Implications
Examples can be downloaded and ran individually.