-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Natural Earth URL #1833
Update Natural Earth URL #1833
Conversation
Tested locally by running one of the gallery examples, and got a warning that suggested the files were indeed coming from the new location. |
Looks good to me! |
Thanks @dopplershift! |
I've updated cartopy to 0.19.0 and it worked locally, but it is still trying to download the shapefiles from the old url when I execute the scripit within a Jupyter notebook with Binder. Please, am I missing something? |
Did you download the updated copy of the script from this repo? |
No, I haven't because the installation of version 0.19.0 through conda-forge had worked locally. For the remote execution I specified this version in the environment.yml file in my github repo. This exceeds my Python knowledge, thus could you please explain how this script should be used when remotely running cartopy in a jupyter notebook? |
I just tested and downloading is working great from AWS using the updated shapereader.py script. |
Honestly, it sounds like the best solution is to get the Binder to regenerate the Docker image it's using with the latest cartopy from conda-forge, which has been patched to use the updated URL. You may also be able to trigger this inside a notebook with |
Hi! I've been trying to use the |
@jdldeauna I have no expertise on this, but there was a suggestion at #1846 (comment) to try
|
Folks, here is something that worked for me: At first I was explicitly requesting the dependence of version 0.19.0 in my environment.yml, just I've done in my local environment, which was working fine. This version was installed in the image created by the docker as expected, but the script was still trying to download from the old url. However, when the command I can't say if it was an issue with the conda-forge channel for cartopy or if it was some bug with the docker image, but I think that this version discrepance between those from the explicit dependence and the installation through conda may be the cause of malfunction related by the other users as well. Thank you all for your support! |
Thanks for the helpful tips! |
This is my first Cartopy PR, so apologies if I've missed something!
Rationale
Updated the URL for Natural Earth feature downloads, following the AWS template provided by @acarapetis at #1325 (comment). @greglucas stated at #1325 (comment) that he thinks AWS is the official replacement for the https://naciscdn.org/ source (which has been rather intermittent in recent weeks).
Implications
Hopefully the shapefile downloads will become a bit more reliable.