-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport PRs for 0.20.1 #1904
Backport PRs for 0.20.1 #1904
Conversation
Due to a change [1] after beta1, this image has altered somewhat. [1] matplotlib/matplotlib#19619
The test tolerance is too high, and random other changes have crept in so that some show numbers that are completely different from the reference image. * 726ebac changed the `Mercator` projection in `test_set_xyticks` to use the default globe, which changed the text of the ticks from degree-ish to metres. * Ticks are quite clearly requested at 30° increments in `test_set_yticks_cylindrical`, so they definitely should not be at ±31/75°. * Also, fix some small inconsistencies in the tests.
added missing shapefile group to download script
Due to a change [1] after beta1, this image has altered somewhat. [1] matplotlib/matplotlib#19619
instead of hard-coding PlateCarree.
Is there anything not included here? Could we just branch off of the current master for v0.20.x |
Lots of refactoring in master |
FIX: pcolor shading with nearest
@@ -26,11 +26,11 @@ | |||
|
|||
import fnmatch | |||
import os | |||
import shutil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E402 module level import not at top of file
import subprocess | ||
import warnings | ||
from collections import defaultdict | ||
from distutils.spawn import find_executable | ||
from distutils.sysconfig import get_config_var | ||
from sysconfig import get_config_var |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E402 module level import not at top of file
I don't seem to be able to restart AppVeyor, but it seems unrelated. And the stickler CI bits can be ignored. |
Agreed that they are unrelated. Feel free to tag the v0.20.1 release whenever now. I think you've got all of the MPL 3.5 issues worked out, but I haven't built with the older freetype from master so I haven't done a full end-to-end test myself yet. |
You can just |
Rationale
At the very least, we should release with #1899 for fixing tests with latest Matplotlib. Maybe just waiting for one more thing on the milestone.
Implications
Bug fixes.