Explicitly calling numpy asanyarray over the inputs. #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applying asanyarray to x, y, u, v, and all possible scalars to allow the use of objects that implements a __array__, like xarray.DataArray.
greglucas
approved these changes
May 24, 2022
The test is a replica of the test test_with_scalar_field but all inputs are converted to lists.
|
Just added a test following your idea, thanks! |
|
Thanks, @axnsantana, hope to see some more contributions from you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying asanyarray to x, y, u, v, and all possible scalars to allow the
use of objects that implements a
__array__, likexarray.DataArray.Rationale
Cartopy was falling when non-ndarray inputs like
xarray.DataArrayis used.More details on issue #2049