FIX: close the path on GeoSpines around the boundary #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GeoSpine class surrounds the entire region and thus should be closed. Previously, there would be a small gap at the corner of closure due to the capstyle of the lines being "butt" by default. To avoid any capstyle issues, we can just set the path to be closed.
QuLogic
approved these changes
Jun 6, 2023
dopplershift
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GeoSpine class surrounds the entire region and thus should be closed. Previously, there would be a small gap at the corner of closure due to the capstyle of the lines being "butt" by default. To avoid any capstyle issues, we can just set the path to be closed.
Most of the updates were quite small, but the images were already small enough so they seemed reasonable to change. I did bump the tolerance on one image because it was such an even smaller change to 0.03.
closes #2184
Rationale
Implications