FIX: _trigger_patch_reclip takes axes instance
#2441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
According to the Axes documentation, the callbacks attached to an axes "will be called with func(ax) where ax is the
Axesinstance." So changed the_trigger_patch_reclipfunction to expect the axes rather than the event. This fix was prompted by this StackOverflow question and the new test adapted from that. Note that the axes property of a normal axes is itself, but the axes property of an inset axes is its parent. Unfortunately the test coverage of this callback is minimal: when I removed it completely, the only test failure I got was here, wherelabelsbecame an empty list.Implications