-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relicense from LGPL-3 to BSD-3 #331
Conversation
@lbdreyer Test failure to investigate, but not your doing... 🤔 |
I think that test failure is just a method that shouldn't start with "test". cf-units/cf_units/tests/unit/unit/test_Unit.py Lines 82 to 94 in 2a164dc
Edit: nope, that's just a warning I'm looking at. I'll open a PR to fix the warning anyway.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bjlittle not your doing
Not so sure.
I think the two files mentioned did get missed in updating the licence header.
So, I think these tweaks may fix what was wrong?
Haven't really checked anything else yet, but I'm sure it's right in spirit.
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
Thanks for catching the problem @pp-mo ! The changes should now be correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-reviewing this to approve.
But I can't understand why this is necessary, since it lists no unresolved conversations.
Seen this before, I think it is possibly a GitHub bug ??
Thanks @pp-mo ! |
All the code in this repo comes from contributors who have now either signed the new CLA or are employees of the Met Office.
The new CLA enables us to relicense to BSD-3.
This PR: