auto check setuptools manifest #350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 17, 2023
Merged
| exclude .pre-commit-config.yaml | ||
| exclude .readthedocs.yml | ||
| exclude CHANGES |
There was a problem hiding this comment.
Suggested change
| exclude CHANGES |
In light of #351
| jobs: | ||
| manifest: | ||
| name: "check-manifest" | ||
| uses: scitools/workflows/.github/workflows/ci-manifest.yml@2023.04.3 |
There was a problem hiding this comment.
Suggested change
| uses: scitools/workflows/.github/workflows/ci-manifest.yml@2023.04.3 | |
| uses: scitools/workflows/.github/workflows/ci-manifest.yml@2023.09.1 |
There was a problem hiding this comment.
Should we make a point of what we include, too?
E.g. LICENSE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR ensures that the assets packaged for the PyPI sdist and wheel are as expected by performing an automated GHA check of the payload manifest.
Adopts the reusable
SciToolsGHA workflow, which will be automagically updated thanks to the already configureddependabot.Note that, this PR fixes several discrepancies.