Port tests from iris/tests/integration/test_grib_save.py#198
Merged
pp-mo merged 2 commits intoSciTools:masterfrom Feb 21, 2020
Merged
Port tests from iris/tests/integration/test_grib_save.py#198pp-mo merged 2 commits intoSciTools:masterfrom
pp-mo merged 2 commits intoSciTools:masterfrom
Conversation
This was referenced Feb 21, 2020
lbdreyer
commented
Feb 21, 2020
| def _lat_lon_cube_no_time(self): | ||
| """ | ||
| Returns a cube with a latitude and longitude suitable for testing | ||
| saving to PP/NetCDF etc. |
Member
Author
There was a problem hiding this comment.
I suppose this no longer makes sense in the context of testing for GRIB.
I'll change this docstring
Member
Author
|
I've now updated this PR with an extra commit that edit the tests slightly to make them more understandable in the context of iris_grib |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR: SciTools/iris#3669
Basically a lift and shift of the tests in iris/tests/integration/test_grib_save.py other than the minor necessary changes such as inherit from
iris_grib.tests.IrisGribTestrather thaniris.tests.IrisTestI just moved it to a file called iris_grib/tests/integration/save_rules/test_grib_save.py as I thought that would be the easiest to review, but I could move it somewhere more sensible, iris_grib/tests/integration/save_rules/init.py for example.