Tests for saving other-format data into grib : ported from Iris.#213
Merged
trexfeathers merged 2 commits intoSciTools:masterfrom Jun 24, 2020
Merged
Tests for saving other-format data into grib : ported from Iris.#213trexfeathers merged 2 commits intoSciTools:masterfrom
trexfeathers merged 2 commits intoSciTools:masterfrom
Conversation
Member
Author
Well, the need for mo-pack here shows exactly what that meant ! |
Contributor
😨 😨 |
trexfeathers
approved these changes
Jun 24, 2020
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Looks good, thanks @pp-mo
|
|
||
| class TestNameToGRIB(tests.IrisGribTest): | ||
| def check_common(self, name_cube, grib_cube): | ||
| self.assertTrue(np.allclose(name_cube.data, grib_cube.data)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are ported directly across from these iris integration tests.
The aim of taking these tests out of Iris is so that we can avoid any need for iris-grib within Iris' own tests.
(not quite there yet, but coming soon...)
That linkage is a headache because at present each requires the other for testing : Therefore, any breaking change (that requires parallel changes to both) can prevent both from passing tests, until both cut new releases.
NOTE: migrating these tests here still leaves open a possible future dependency problem ...
If in future we "split out" either of these other file-formats (name + pp) to a separate package, as we have done with iris-grib itself, that will make iris-grib testing depend on those other file-format packages.
I propose that we simply leave that as a "problem for the future".