Adopt newstyle dependencies; fix travis to suit.#229
Merged
trexfeathers merged 1 commit intoSciTools:masterfrom Oct 5, 2020
Merged
Adopt newstyle dependencies; fix travis to suit.#229trexfeathers merged 1 commit intoSciTools:masterfrom
trexfeathers merged 1 commit intoSciTools:masterfrom
Conversation
Member
Author
|
When we have this agreed + merged, I will re-introduce the test-against-Iris-master code. |
trexfeathers
reviewed
Oct 5, 2020
Contributor
trexfeathers
left a comment
There was a problem hiding this comment.
Looks good @pp-mo
Just one question outstanding from my own PR
Member
Author
|
Re:
In my understanding, the wheel package is only required if you want to build wheels. So, I think this would only be needed if you need to do a "setup.py bdist_wheel", |
trexfeathers
approved these changes
Oct 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically the content of #226 , which it aims to replace.
except ...
You can compare the .travis.yml directly with the one from #226
: trexfeathers/iris-grib@iris-latest...pp-mo:new_deps#diff-354f30a63fb0907d4ad57269548329e3
The whole of this doesn't compare well with #226, owing to changes since.
But the things that this PR affects are intelligible, essentially unchanged from #226 and can be compared to master (i.e. in "files changed")