Skip to content

Adopt newstyle dependencies; fix travis to suit.#229

Merged
trexfeathers merged 1 commit intoSciTools:masterfrom
pp-mo:new_deps
Oct 5, 2020
Merged

Adopt newstyle dependencies; fix travis to suit.#229
trexfeathers merged 1 commit intoSciTools:masterfrom
pp-mo:new_deps

Conversation

@pp-mo
Copy link
Member

@pp-mo pp-mo commented Oct 5, 2020

This is basically the content of #226 , which it aims to replace.
except ...

  • rebased onto latest master
  • fixed .travis.yml to get it all working (I hope)
  • removed (for now) the code to test against latest-Iris instead of latest-release : just to simplify the PR

You can compare the .travis.yml directly with the one from #226
: trexfeathers/iris-grib@iris-latest...pp-mo:new_deps#diff-354f30a63fb0907d4ad57269548329e3

The whole of this doesn't compare well with #226, owing to changes since.
But the things that this PR affects are intelligible, essentially unchanged from #226 and can be compared to master (i.e. in "files changed")

@pp-mo pp-mo requested a review from trexfeathers October 5, 2020 12:13
@pp-mo pp-mo added this to the v0.16.0 milestone Oct 5, 2020
@pp-mo
Copy link
Member Author

pp-mo commented Oct 5, 2020

When we have this agreed + merged, I will re-introduce the test-against-Iris-master code.
We will get that running + testing, but possibly in a feature-branch as to work it needs test changes which will then break testing with the old Iris release.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.482% when pulling c29acfb on pp-mo:new_deps into 6e2e65d on SciTools:master.

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @pp-mo

Just one question outstanding from my own PR

@pp-mo
Copy link
Member Author

pp-mo commented Oct 5, 2020

Re:

Is it appropriate to include wheel in here too?

In my understanding, the wheel package is only required if you want to build wheels.
cf. https://github.com/pypa/wheel

So, I think this would only be needed if you need to do a "setup.py bdist_wheel",
thus, no reason to require it here.

@trexfeathers trexfeathers merged commit ad6c676 into SciTools:master Oct 5, 2020
@pp-mo pp-mo deleted the new_deps branch March 3, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants