-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-generate zero data for missing data payload #362
Conversation
@pp-mo As a result of this fix, we now have "unexpected successes" in the tests regarding pickling. We could now simply not mark these tests are expected failures. How would you like to proceed? |
1d9e159
to
0537bfe
Compare
Out of curiosity, I remove the |
After some chat, I think this is OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you want to follow a tiny suggestion..
good to go I think
@pp-mo Sweet, cheers 💯 |
This pull-request extends the capability of the
iris_grib.message._DataProxy
to detect and auto-generate missing data payload for a GRIB2 message.The scenario is that the message data payload is all zero, and rather than serialize this within the message, thus increasing the footprint, an application can generate the data at runtime whenever the Data Representation Section [5] has
bitsPerValue=0
and an empty Data Section [7].Failure to support this extension results in no encoded Data Section [7] within a
iris_grib.message._RawGribMessage
causing aKeyError
traceback within the user script. The impact of this is that an N-D Iris cube can be loaded but whenever at least one GRIB2 message has such missing data, touching the cube data will result in this failure.Reference: SciTools/iris-test-data#89