Dask masked fix #87
Merged
Dask masked fix #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp-mo
force-pushed
the
dask_masked_fix
branch
from
5cb7c48 to
c8d3636
Compare
pelson
reviewed
Oct 24, 2017
| @@ -145,7 +145,6 @@ class GribWrapper(object): | |||
| def __init__(self, grib_message, grib_fh=None): | |||
| """Store the grib message and compute our extra keys.""" | |||
| self.grib_message = grib_message | |||
| self.realised_dtype = np.array([0.]).dtype | |||
There was a problem hiding this comment.
Well, not if we never released the previous version, no ? ;-)
| @@ -698,6 +694,10 @@ def _message_values(grib_message, shape): | |||
| data = gribapi.grib_get_double_array(grib_message, 'values') | |||
| data = data.reshape(shape) | |||
|
|
|||
| # Handle missing values in a sensible way. | |||
There was a problem hiding this comment.
Is this a hangover from not having masks?
There was a problem hiding this comment.
Not totally sure.
This is simply reflecting what is currently in Iris master.
| # We can't use the cube's fill value if it's NaN, | ||
| # the GRIB API doesn't like it. | ||
| # Calculate an MDI outside the data range. | ||
| min, max = cube.data.min(), cube.data.max() | ||
| fill_value = min - (max - min) * 0.1 | ||
| # Prepare the unmasked data array, using fill_value as the MDI. | ||
| data = cube.data.filled(fill_value) |
|
Changes Unknown when pulling c8d3636 on pp-mo:dask_masked_fix into ** on SciTools:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring iris_grib up-to-date with recent changes to Iris,
to use masked-arrays instead of nan masking in Dask (Dask v 0.13).