Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature complete : mergeback 2d_coords #3100

Closed
pp-mo opened this issue Jul 30, 2018 · 1 comment
Closed

Feature complete : mergeback 2d_coords #3100

pp-mo opened this issue Jul 30, 2018 · 1 comment

Comments

@pp-mo
Copy link
Member

pp-mo commented Jul 30, 2018

Master ticket for completing current work on 2d_coords (part of ORCA data support effort).

Rationale :

  • in the end, the 2d_coords branch will eventually be ok to merge back
  • in development, we will want to merge in PRs that don't meet our usual standards
    • incomplete implementation
    • known problems
    • temporary limitations
    • documentation needs fixing
    • temporary implementation awaiting other outstanding work for a better solution
  • in these cases, all the outstanding work needs to be recorded in issues marked with the '2d_coords' label.
  • broken tests can skipped during development using "@skip_2d" Provide a test skipper for 2d coords WIP. #3099
  • once all open issues+prs labelled 2d_coords are closed (in theory),
    everything is up to standard + we can merge back.
@pp-mo pp-mo changed the title Mergeback 2d_coords Feature complete : mergeback 2d_coords Jul 30, 2018
@DPeterK
Copy link
Member

DPeterK commented Oct 3, 2018

Done in #3153.

@DPeterK DPeterK closed this as completed Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants