Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale GHA instructions to reopen issue do not work for non GitHub team members #4628

Closed
tkknight opened this issue Mar 9, 2022 · 5 comments · Fixed by #5522
Closed

Stale GHA instructions to reopen issue do not work for non GitHub team members #4628

tkknight opened this issue Mar 9, 2022 · 5 comments · Fixed by #5522
Assignees

Comments

@tkknight
Copy link
Contributor

tkknight commented Mar 9, 2022

🐛 Bug Report

How To Reproduce

Steps to reproduce the behaviour:

  1. The stale GitHub action suggests to mention @SciTools/iris-devs to have a stale issue re-opened, however we have learned a mention can only be done by someone already in the GitHub team.

Expected behaviour

The stale comments should state a way that works.

Environment

N/A

Additional context

A GitHub action (GHA) could be created to look for specific text such as /not stale or ping @Scitools/iris-devs on a new issue comment that will then add a comment itself and mention the team, I think the GHA will have permission to do this (needs testing).

conda-forge does something similar as per the comment in #4617.

Alternatively a GHA could be triggered to just reopen the issue, similar to the above but triggred by /reopen.

@bjlittle
Copy link
Member

Also see #4133, which is another use case where we want non-members of SciTools to be able to easily @mention us to get our attention

@wjbenfold
Copy link
Contributor

This is also assumed to work in the developer guide here: https://scitools-iris.readthedocs.io/en/stable/developers_guide/contributing_documentation_easy.html

@tkknight
Copy link
Contributor Author

Mentioneing a group is also not allowed in a GitHub Action unless you create a personal access token according to this: https://github.saobby.my.eu.orgmunity/t/team-mention-from-bot-not-working/144323

@github-actions
Copy link
Contributor

In order to maintain a backlog of relevant issues, we automatically label them as stale after 500 days of inactivity.

If this issue is still important to you, then please comment on this issue and the stale label will be removed.

Otherwise this issue will be automatically closed in 28 days time.

@github-actions github-actions bot added the Stale A stale issue/pull-request label Aug 20, 2023
@github-actions github-actions bot removed the Stale A stale issue/pull-request label Aug 31, 2023
@trexfeathers
Copy link
Contributor

Discussion in @SciTools/peloton: a full solution to the tagging problem involving GHA is over-engineered. Modifying the comment to NOT suggest tagging seems like a good enough solution.

@scitools-ci scitools-ci bot removed this from 🚴 Peloton Oct 29, 2023
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Oct 30, 2023
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Oct 31, 2023
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Nov 1, 2023
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Nov 2, 2023
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Nov 3, 2023
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Nov 4, 2023
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Nov 5, 2023
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Nov 6, 2023
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Nov 7, 2023
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants