-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include mesh location in cube printout #4756
Comments
I think it also makes sense to print "the mesh"
So, I think the key question is where+how should this info appear in the cube listing.
Might now look like ...
Some reasons:
Opinions ?!? |
I'd put it out of the coordinates - it's not a coordinate and I'd find it confusing to have it in there breaking up the coordinates. That said, I'd far rather this happened in some way and then we can tweak it if we want it moving when we have more mesh users, rather than people spending ages discussing where it perfectly goes and it never getting implemented, so I'm happy with wherever the person who picks up this ticket decides to put it |
At the risk of turning this into a discussion thread To provide this info without a significant re-think to the existing "cube summary object" and "cube printout" implementations, I think the mesh/location info can only go into a new cube summary "section", which then must be either a 'vector' section (i.e. it participates in the dims-map), or a 'scalar' one. So, I wrote a nasty hacky bit of code to populate a cube with all possible sections.
So, I the benefit of presenting it as a "vector" section, as above, is that you can put it alongside the mesh-coords within the dims map, and also highlight that it links to the mesh dimension. But, as pointed out, it isn't a coord or any sort of 'dimensional metadata' component, so it doesn't really belong there. However, if we provide a "scalar" Mesh section, then the awkward part is that it may be some way away from the primary coordinate info in the dims map. The best we can do is put it as the first scalar section.
What do we think, user-champions ? |
Looks good, @pp-mo.
Having a |
closed by #4778 |
✨ Feature Request
In the cube printout, include the mesh location.
Motivation
This important information is currently absent
The text was updated successfully, but these errors were encountered: