Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate "CubeList._repr_html_" method. #4973

Closed
pp-mo opened this issue Sep 20, 2022 · 1 comment
Closed

Reinstate "CubeList._repr_html_" method. #4973

pp-mo opened this issue Sep 20, 2022 · 1 comment
Labels
Feature: ESMValTool Peloton 🚴‍♂️ Target a breakaway issue to be caught and closed by the peloton Type: Bug

Comments

@pp-mo
Copy link
Member

pp-mo commented Sep 20, 2022 •
edited
Loading

🐛 Bug Report

How To Reproduce

CubeList([])._repr_html_() ought to produce an html string,
but instead fails with a simple
AttributeError: 'CubeList' object has no attribute '_repr_html_'

Notes

Seems to be a bug introduced in #4767

We already test the behaviour of CubeListRepresentation.repr_html()
But tests don't call CubeList._repr_html_ itself.

Fix should include a test that CubeList._repr_html_

  1. exists,
  2. creates a CubeListRepresentation, and
  3. calls its repr_html
    (can be mock-ist)
@pp-mo pp-mo mentioned this issue Sep 20, 2022
Merged
@pp-mo pp-mo added Feature: ESMValTool Peloton 🚴‍♂️ Target a breakaway issue to be caught and closed by the peloton labels Sep 20, 2022
@pp-mo pp-mo mentioned this issue Sep 21, 2022
Merged
1 task
@valeriupredoi valeriupredoi mentioned this issue Sep 30, 2022
Open
@rcomer
Copy link
Member

rcomer commented Oct 16, 2022

This was done at #4976 and merged back into main at #5004.

@rcomer rcomer closed this as completed Oct 16, 2022
Repository owner moved this from 📚 Backlog to 🏁 Done in 🌍 ESMValTool Surgery (Discussion Topics) Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature: ESMValTool Peloton 🚴‍♂️ Target a breakaway issue to be caught and closed by the peloton Type: Bug
Projects
No open projects
🌍 ESMValTool Surgery (Discussion Topics)
Status: 🏁 Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pp-mo @rcomer