-
Notifications
You must be signed in to change notification settings - Fork 6
fix: resolve streaming not displaying for ReAct/simple agents #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: 请再次确认将节点名称硬编码为 "agent" 是否总是适合作为合成的 node_start 事件名称。
这里使用
"agent"意味着所有合成的 node_start 事件都共享相同的节点标识符。如果不同的预构建 agent(或未来新增的)应该有各自不同的节点名称,这可能会影响可追踪性,或者与其他命名约定冲突。建议考虑从ctx中推导名称(例如基于 agent 类型 / 配置),或者为默认名称定义一个共享常量,以便在需要时可以集中修改。Original comment in English
question: Double-check whether the hardcoded node name "agent" is always appropriate for synthetic node_start events.
Using
"agent"here assumes all synthetic node_start events share the same node identifier. If different prebuilt agents (or future ones) should have distinct node names, this could hurt traceability or clash with other naming conventions. Consider deriving the name fromctx(e.g., agent type/config), or defining a shared constant for the default name so it can be changed centrally.