🐛fix: better secretcode

[xinquiry]

变更内容

• 新功能
• 修复 Bug
• 增强重构
• 其他（请描述）

简要描述本次 PR 的主要变更内容。

相关 Issue

请关联相关 Issue（如有）：#编号

检查清单

默认已勾选，如不满足，请检查。

• 已在本地测试通过
• 已补充/更新相关文档
• 已添加测试用例
• 代码风格已经过 pre-commit 钩子检查

其他说明

如有特殊说明或注意事项，请补充。

Summary by Sourcery

根据 URL 哈希（hash）而不是 pathname 来路由秘密代码管理页面，以改善导航行为。

新功能：

• 支持通过 #secretcode URL 哈希访问秘密代码页面。

改进：

• 在主应用布局中跟踪并响应 location.hash 的变化，包括 hashchange 事件。
• 更新秘密代码页面的关闭行为，从执行整页导航改为清除 URL 哈希。

Original summary in English

Summary by Sourcery

Route the secret code admin page based on URL hash instead of pathname to improve navigation behavior.

New Features:

• Support accessing the secret code page via the #secretcode URL hash.

Enhancements:

• Track and react to location.hash changes, including hashchange events, in the main app layout.
• Update the secret code page close behavior to clear the URL hash instead of performing a full page navigation.

[sourcery-ai]

审查者指南（在小型 PR 上折叠）

审查者指南

将密钥路由从基于 pathname 的检测切换为基于 hash 的检测，并调整关闭行为，在更新 URL hash 的同时避免执行完整页面导航。

基于 hash 的密钥路由时序图

sequenceDiagram
    actor User
    participant Browser
    participant Xyzen
    participant SecretCodePage

    User->>Browser: Navigate to URL with #secretcode
    Browser->>Browser: Update location.hash to #secretcode
    Browser->>Xyzen: Trigger hashchange event
    Xyzen->>Xyzen: setCurrentHash(location.hash)
    Xyzen->>Xyzen: currentHash === #secretcode
    Xyzen->>Browser: Render SecretCodePage
    Browser->>User: Display SecretCodePage

    User->>SecretCodePage: Click Close button
    SecretCodePage->>Browser: Set location.hash = empty string
    Browser->>Browser: Trigger hashchange event
    Browser->>Xyzen: hashchange event
    Xyzen->>Xyzen: setCurrentHash(empty string)
    Xyzen->>Xyzen: currentHash !== #secretcode
    Xyzen->>Browser: Render main application view
    Browser->>User: Show main application instead of SecretCodePage

Loading

文件级变更

变更	详情	文件
通过追踪 URL hash 而不是 pathname 来决定何时渲染密钥页面。	用用于追踪当前 pathname 的 state 替换为用于追踪当前 hash 的 state，并从 window.location.hash 初始化。 更新 effect，注册基于 hash 的导航监听器，同时使用 popstate 和 hashchange 事件，并在组件卸载时清理它们。 使用当前 URL hash（"#secretcode"）而不是 pathname（"/secretcode"）来决定何时渲染 SecretCodePage。	web/src/app/App.tsx
将 SecretCodePage 的关闭行为从导航到根路径改为清空 URL hash。	更新关闭按钮点击处理函数，将 window.location.hash 设置为空字符串，而不是将 window.location.href 更新为 "/"。	web/src/components/admin/SecretCodePage.tsx

---

提示与命令

与 Sourcery 交互

• 触发新的审查： 在 pull request 中评论 @sourcery-ai review。
• 继续讨论： 直接回复 Sourcery 的审查评论。
• 从审查评论生成 GitHub issue： 在某条审查评论下回复，要求 Sourcery 从该评论创建 issue。你也可以在该审查评论下回复 @sourcery-ai issue 来从中创建 issue。
• 生成 pull request 标题： 在 pull request 标题的任意位置写入 @sourcery-ai，即可随时生成标题。你也可以在 pull request 中评论 @sourcery-ai title 来（重新）生成标题。
• 生成 pull request 摘要： 在 pull request 正文任意位置写入 @sourcery-ai summary，即可在你想要的位置随时生成 PR 摘要。你也可以在 pull request 中评论 @sourcery-ai summary 来（重新）生成摘要。
• 生成审查者指南： 在 pull request 中评论 @sourcery-ai guide，即可随时（重新）生成审查者指南。
• 解决所有 Sourcery 评论： 在 pull request 中评论 @sourcery-ai resolve，即可解决所有 Sourcery 评论。适用于你已经处理完所有评论且不再希望看到它们的情况。
• 忽略所有 Sourcery 审查： 在 pull request 中评论 @sourcery-ai dismiss，即可忽略所有现有的 Sourcery 审查。特别适用于你希望从一次全新的审查开始——别忘了再评论 @sourcery-ai review 来触发新的审查！

自定义你的使用体验

访问你的 dashboard 以：

• 启用或禁用审查特性，例如由 Sourcery 生成的 pull request 摘要、审查者指南等。
• 更改审查语言。
• 添加、删除或编辑自定义审查说明。
• 调整其他审查设置。

获取帮助

• 联系支持团队 以获取帮助或提供反馈。
• 访问我们的文档以查看详细指南和信息。
• 通过在 X/Twitter、LinkedIn 或 GitHub 上关注我们，与 Sourcery 团队保持联系。

Original review guide in English

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Switches secret code routing from pathname-based detection to hash-based detection and aligns the close behavior to update the URL hash instead of performing a full navigation.

Sequence diagram for hash-based secret code routing

sequenceDiagram
    actor User
    participant Browser
    participant Xyzen
    participant SecretCodePage

    User->>Browser: Navigate to URL with #secretcode
    Browser->>Browser: Update location.hash to #secretcode
    Browser->>Xyzen: Trigger hashchange event
    Xyzen->>Xyzen: setCurrentHash(location.hash)
    Xyzen->>Xyzen: currentHash === #secretcode
    Xyzen->>Browser: Render SecretCodePage
    Browser->>User: Display SecretCodePage

    User->>SecretCodePage: Click Close button
    SecretCodePage->>Browser: Set location.hash = empty string
    Browser->>Browser: Trigger hashchange event
    Browser->>Xyzen: hashchange event
    Xyzen->>Xyzen: setCurrentHash(empty string)
    Xyzen->>Xyzen: currentHash !== #secretcode
    Xyzen->>Browser: Render main application view
    Browser->>User: Show main application instead of SecretCodePage

Loading

File-Level Changes

Change	Details	Files
Track URL hash instead of pathname to determine when to render the secret code page.	Replace state for tracking current pathname with state for tracking current hash, initializing from window.location.hash. Update effect to register a hash-based navigation listener using both popstate and hashchange events and clean them up on unmount. Use the current URL hash ("#secretcode") instead of pathname ("/secretcode") to decide when to render SecretCodePage.	web/src/app/App.tsx
Change the SecretCodePage close action to clear the URL hash rather than navigate to the root path.	Update the close button click handler to set window.location.hash to an empty string instead of updating window.location.href to "/".	web/src/components/admin/SecretCodePage.tsx

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

你好，我已经审查了你的修改，这里有一些反馈：

• 在切换到基于 hash 的路由后，就不再需要通过 popstate 监听器来跟踪 window.location.hash 了，所以你可以移除 popstate 处理函数，只依赖 hashchange 事件来简化这个 effect。
• 在 SSR 场景下，用于 currentHash 的 useState 初始化函数会在服务端运行，并且不会在客户端重新计算，因此即使 URL 已经带有 hash，currentHash 仍可能保持为空字符串；建议在组件挂载时，在 useEffect 中通过 window.location.hash 设置 currentHash，以确保在 hydration 之后初始状态是正确的。

给 AI Agent 的提示

Please address the comments from this code review:

## Overall Comments
- 在切换到基于 hash 的路由后，就不再需要通过 `popstate` 监听器来跟踪 `window.location.hash` 了，所以你可以移除 `popstate` 处理函数，只依赖 `hashchange` 事件来简化这个 effect。
- 在 SSR 场景下，用于 `currentHash` 的 `useState` 初始化函数会在服务端运行，并且不会在客户端重新计算，因此即使 URL 已经带有 hash，`currentHash` 仍可能保持为空字符串；建议在组件挂载时，在 `useEffect` 中通过 `window.location.hash` 设置 `currentHash`，以确保在 hydration 之后初始状态是正确的。

---

Sourcery 对开源项目是免费的——如果你觉得我们的评审有帮助，请考虑分享给更多人 ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈改进后续的评审。}

Original comment in English

Hey there - I've reviewed your changes - here's some feedback:

• When switching to hash-based routing, the popstate listener is no longer necessary for tracking window.location.hash, so you can drop the popstate handler and rely solely on the hashchange event to simplify the effect.
• With SSR, the useState initializer for currentHash will run on the server and not be recomputed on the client, so currentHash may stay as an empty string even if the URL already has a hash; consider setting currentHash from window.location.hash inside the useEffect on mount to ensure correct initial state after hydration.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- When switching to hash-based routing, the `popstate` listener is no longer necessary for tracking `window.location.hash`, so you can drop the `popstate` handler and rely solely on the `hashchange` event to simplify the effect.
- With SSR, the `useState` initializer for `currentHash` will run on the server and not be recomputed on the client, so `currentHash` may stay as an empty string even if the URL already has a hash; consider setting `currentHash` from `window.location.hash` inside the `useEffect` on mount to ensure correct initial state after hydration.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}