Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sequester crypto #3629

Merged
merged 42 commits into from
Dec 28, 2022
Merged

Add sequester crypto #3629

merged 42 commits into from
Dec 28, 2022

Conversation

TimeEngineer
Copy link
Contributor

@TimeEngineer TimeEngineer commented Nov 28, 2022

What has changed ?

Oxidize sequester keys

  • Does this PR affect the User ?

closes #3637 #3638

@TimeEngineer TimeEngineer self-assigned this Nov 28, 2022
@TimeEngineer TimeEngineer added refactor I-Python Impact: Python-related stuff I-Rust Impact: Rust-related stuff labels Nov 28, 2022
@TimeEngineer TimeEngineer force-pushed the oxidation-add-sequester-crypto branch 6 times, most recently from 830c5e1 to a21c6a0 Compare November 28, 2022 21:54
@TimeEngineer TimeEngineer marked this pull request as ready for review November 28, 2022 21:54
Copy link
Contributor

@FirelightFlagboy FirelightFlagboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does EnforeSerialize & EnforeDeserialize use the same values for const ?
If yes we could do something like that

trait AlgorithmInfo {
  const ALGORITHM: &'static [u8];
  const SIZE: usize;
  const BYTE_SIZE: usize = Self::SIZE / 8;
}

trait EnforeSerialize: AlgorithmInfo {
  // ...
}

trait EnforeDeserialize: AlgorithmInfo {
  // ...
}

oxidation/libparsec/crates/crypto/src/common/secret.rs Outdated Show resolved Hide resolved
oxidation/libparsec/crates/crypto/src/common/error.rs Outdated Show resolved Hide resolved
oxidation/libparsec/crates/crypto/src/common/sequester.rs Outdated Show resolved Hide resolved
parsec/core/cli/bootstrap_organization.py Outdated Show resolved Hide resolved
parsec/sequester_export_reader.py Outdated Show resolved Hide resolved
oxidation/libparsec/crates/crypto/src/common/sequester.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Volham22 Volham22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TimeEngineer
Copy link
Contributor Author

Does EnforeSerialize & EnforeDeserialize use the same values for const ? If yes we could do something like that

trait AlgorithmInfo {
  const ALGORITHM: &'static [u8];
  const SIZE: usize;
  const BYTE_SIZE: usize = Self::SIZE / 8;
}

trait EnforeSerialize: AlgorithmInfo {
  // ...
}

trait EnforeDeserialize: AlgorithmInfo {
  // ...
}

So you implement 2 traits for each Key ?

@FirelightFlagboy
Copy link
Contributor

FirelightFlagboy commented Nov 29, 2022

Does EnforeSerialize & EnforeDeserialize use the same values for const ? If yes we could do something like that

trait AlgorithmInfo {
  const ALGORITHM: &'static [u8];
  const SIZE: usize;
  const BYTE_SIZE: usize = Self::SIZE / 8;
}

trait EnforeSerialize: AlgorithmInfo {
  // ...
}

trait EnforeDeserialize: AlgorithmInfo {
  // ...
}

So you implement 2 traits for each Key ?

If we had a type that need to implement both trait it would be nice that they share the same information for both trait.
but in the other case It would be tedious if we had to implement 2 trait if we only need one of Serialization or De-serialization

@TimeEngineer
Copy link
Contributor Author

Does EnforeSerialize & EnforeDeserialize use the same values for const ? If yes we could do something like that

trait AlgorithmInfo {
  const ALGORITHM: &'static [u8];
  const SIZE: usize;
  const BYTE_SIZE: usize = Self::SIZE / 8;
}

trait EnforeSerialize: AlgorithmInfo {
  // ...
}

trait EnforeDeserialize: AlgorithmInfo {
  // ...
}

So you implement 2 traits for each Key ?

If we had a type that need to implement both trait it would be nice that way we share the same information for both trait. but in the other case It would be tedious if we had to implement 2 trait if we only need one of Serialization or De-serialization

You can't implement both trait for the same key

@touilleMan
Copy link
Member

also closes #3327

@TimeEngineer TimeEngineer merged commit 0595739 into master Dec 28, 2022
@TimeEngineer TimeEngineer deleted the oxidation-add-sequester-crypto branch December 28, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-Python Impact: Python-related stuff I-Rust Impact: Rust-related stuff
Projects
None yet
5 participants