-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sequester crypto #3629
Add sequester crypto #3629
Conversation
830c5e1
to
a21c6a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does EnforeSerialize
& EnforeDeserialize
use the same values for const ?
If yes we could do something like that
trait AlgorithmInfo {
const ALGORITHM: &'static [u8];
const SIZE: usize;
const BYTE_SIZE: usize = Self::SIZE / 8;
}
trait EnforeSerialize: AlgorithmInfo {
// ...
}
trait EnforeDeserialize: AlgorithmInfo {
// ...
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
So you implement 2 traits for each |
If we had a type that need to implement both trait it would be nice that they share the same information for both trait. |
52df581
to
f97e6dc
Compare
You can't implement both trait for the same key |
also closes #3327 |
b82ba3e
to
c4c4a48
Compare
Set VCPKG_ROOT only on Windows Ensure CI runs registering of VCPKG_ROOT
Wrong variable name
Try to install vcpkg from cli Force install of openssl from vcpkg Fix windows builds in CI (finally)
vcpkg no longer needed, we build openssl in vendored mode Try to fix windows builds not using strawberry perl
c576a16
to
1b0c7ba
Compare
1b0c7ba
to
a9352fa
Compare
What has changed ?
Oxidize sequester keys
closes #3637 #3638