[Shamir port] Implement greeting procedure #8995
Conversation
vxgmichel
force-pushed
the
issue-8841
branch
2 times, most recently
from
08dde62
to
d8d9e29
Compare
vxgmichel
force-pushed
the
issue-8841
branch
from
d97b906
to
4c9ff67
Compare
| @@ -64,6 +64,9 @@ pub async fn main(args: Args) -> anyhow::Result<()> { | |||
| let ctx = step4_device(ctx).await?; | |||
| save_device(ctx, save_mode).await | |||
| } | |||
| UserOrDeviceClaimInitialCtx::ShamirRecovery(_) => { | |||
| panic!("Shamir recovery invitation is not supported") | |||
There was a problem hiding this comment.
Return an error instead of panicing
There was a problem hiding this comment.
Yes, it's part of the todo list
There was a problem hiding this comment.
I mark the PR as a draft then
| if cfg!(test) | ||
| && recovery_device |
There was a problem hiding this comment.
| if cfg!(test) | |
| && recovery_device | |
| #[cfg!(test)] | |
| if recovery_device |
There was a problem hiding this comment.
This suggestion would complain about recovery_device being mut
| }; | ||
|
|
||
| #[parsec_test(testbed = "shamir", with_server)] | ||
| async fn shamir(tmp_path: TmpPath, env: &TestbedEnv) { |
There was a problem hiding this comment.
This function is long, I would split it using sub-function
There was a problem hiding this comment.
I don't really the point in splitting a single test scenario into subfunction.
There could be multiple smaller tests but I like to have at least one test for testing the full scenario. My plan is to add more smaller tests around it for edge cases.
There was a problem hiding this comment.
Having sub-function simplify reading the test since you wont need to read its implementation first
do_a();
do_b();
check_c();
| ) -> Result<ShamirRecoveryShareData, CertifListShamirRecoveryError> { | ||
| ops.store | ||
| .for_read(|store| async move { | ||
| // TODO: check that the shamir is actually recoverable |
There was a problem hiding this comment.
Meaning that enough recipient are still here / not revoked ?
Close #8841
TODO: